<p>Patrick Rudolph <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/20501">View Change</a></p><p>Patch set 6:</p><p style="white-space: pre-wrap; word-wrap: break-word;">With that fixed all boards seem ready to be pushed.</p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/devicetree.cb">File src/mainboard/hp/8460p/devicetree.cb:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/devicetree.cb@17">Patch Set #6, Line 17:</a> <code style="font-family:monospace,monospace">chip northbridge/intel/sandybridge # FIXME: check gfx.ndid and gfx.did</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">remove all FIXMEs</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/devicetree.cb@18">Patch Set #6, Line 18:</a> <code style="font-family:monospace,monospace">     register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410, 0x80000410, 0x00000005 }"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">last two elements can be removed ad gfx.ndid is 3</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/romstage.c">File src/mainboard/hp/8460p/romstage.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/romstage.c@34">Patch Set #6, Line 34:</a> <code style="font-family:monospace,monospace">{</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">On Ivybridge I've done:<br>RCBA32(FD) = PCH_DISABLE_ALWAYS | 0x10001fe0;<br>Bits that should be always disabled + reserved bits.<br>Applies to all boards.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/20501">change 20501</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20501"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I9c42723ba240a2e9b46998c1a8a708aebc66c604 </div>
<div style="display:none"> Gerrit-Change-Number: 20501 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: Iru Cai <mytbk920423@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 27 Jul 2017 15:39:41 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>