[coreboot-gerrit] Change in libgfxinit[master]: gma-connectors: Add Initialize() procedure

[Nico Huber (Code Review)]

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/20128 )

Change subject: gma-connectors: Add Initialize() procedure
......................................................................

gma-connectors: Add Initialize() procedure

Change-Id: I62946152da9a93b881e0b0ea4b2679086ec8e970
Signed-off-by: Nico Huber <nico.huber at secunet.com>
Reviewed-on: https://review.coreboot.org/20128
Tested-by: Nico Huber <nico.h at gmx.de>
Reviewed-by: Matt DeVillier <matt.devillier at gmail.com>
---
M common/haswell_shared/hw-gfx-gma-connectors.adb
M common/hw-gfx-gma-connectors.ads
M common/hw-gfx-gma.adb
M common/ironlake/hw-gfx-gma-connectors.adb
4 files changed, 18 insertions(+), 0 deletions(-)

Approvals:
  Nico Huber: Verified
  Matt DeVillier: Looks good to me, approved



diff --git a/common/haswell_shared/hw-gfx-gma-connectors.adb b/common/haswell_shared/hw-gfx-gma-connectors.adb
index 734b11a..1af86ac 100644
--- a/common/haswell_shared/hw-gfx-gma-connectors.adb
+++ b/common/haswell_shared/hw-gfx-gma-connectors.adb
@@ -21,6 +21,12 @@
 
 package body HW.GFX.GMA.Connectors is
 
+   procedure Initialize
+   is
+   begin
+      null;
+   end Initialize;
+
    procedure Pre_On
      (Pipe     : in     Pipe_Index;
       Port_Cfg : in     Port_Config;
diff --git a/common/hw-gfx-gma-connectors.ads b/common/hw-gfx-gma-connectors.ads
index ccb9666..30a382f 100644
--- a/common/hw-gfx-gma-connectors.ads
+++ b/common/hw-gfx-gma-connectors.ads
@@ -14,6 +14,11 @@
 
 private package HW.GFX.GMA.Connectors is
 
+   pragma Warnings (GNATprove, Off, "subprogram ""Initialize"" has no effect",
+                    Reason => "Only effects some platforms");
+   procedure Initialize;
+   pragma Warnings (GNATprove, On, "subprogram ""Initialize"" has no effect");
+
    pragma Warnings (GNATprove, Off, "unused variable ""P*""",
                     Reason => "Needed for a common interface");
    procedure Pre_On
diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb
index 21b123d..1aecfab 100644
--- a/common/hw-gfx-gma.adb
+++ b/common/hw-gfx-gma.adb
@@ -364,6 +364,7 @@
 
       Panel.Setup_PP_Sequencer;
       Port_Detect.Initialize;
+      Connectors.Initialize;
 
       if Clean_State then
          Power_And_Clocks.Pre_All_Off;
diff --git a/common/ironlake/hw-gfx-gma-connectors.adb b/common/ironlake/hw-gfx-gma-connectors.adb
index 7d00fa6..8ae47fd 100644
--- a/common/ironlake/hw-gfx-gma-connectors.adb
+++ b/common/ironlake/hw-gfx-gma-connectors.adb
@@ -29,6 +29,12 @@
 package body HW.GFX.GMA.Connectors
 is
 
+   procedure Initialize
+   is
+   begin
+      null;
+   end Initialize;
+
    function Is_Internal (Port_Cfg : Port_Config) return Boolean
    is
    begin

-- 
To view, visit https://review.coreboot.org/20128
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I62946152da9a93b881e0b0ea4b2679086ec8e970
Gerrit-Change-Number: 20128
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170725/aa29e5b6/attachment.html>