<p>Nico Huber <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/20128">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Nico Huber: Verified
  Matt DeVillier: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gma-connectors: Add Initialize() procedure<br><br>Change-Id: I62946152da9a93b881e0b0ea4b2679086ec8e970<br>Signed-off-by: Nico Huber <nico.huber@secunet.com><br>Reviewed-on: https://review.coreboot.org/20128<br>Tested-by: Nico Huber <nico.h@gmx.de><br>Reviewed-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>M common/haswell_shared/hw-gfx-gma-connectors.adb<br>M common/hw-gfx-gma-connectors.ads<br>M common/hw-gfx-gma.adb<br>M common/ironlake/hw-gfx-gma-connectors.adb<br>4 files changed, 18 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/common/haswell_shared/hw-gfx-gma-connectors.adb b/common/haswell_shared/hw-gfx-gma-connectors.adb<br>index 734b11a..1af86ac 100644<br>--- a/common/haswell_shared/hw-gfx-gma-connectors.adb<br>+++ b/common/haswell_shared/hw-gfx-gma-connectors.adb<br>@@ -21,6 +21,12 @@<br> <br> package body HW.GFX.GMA.Connectors is<br> <br>+   procedure Initialize<br>+   is<br>+   begin<br>+      null;<br>+   end Initialize;<br>+<br>    procedure Pre_On<br>      (Pipe     : in     Pipe_Index;<br>       Port_Cfg : in     Port_Config;<br>diff --git a/common/hw-gfx-gma-connectors.ads b/common/hw-gfx-gma-connectors.ads<br>index ccb9666..30a382f 100644<br>--- a/common/hw-gfx-gma-connectors.ads<br>+++ b/common/hw-gfx-gma-connectors.ads<br>@@ -14,6 +14,11 @@<br> <br> private package HW.GFX.GMA.Connectors is<br> <br>+   pragma Warnings (GNATprove, Off, "subprogram ""Initialize"" has no effect",<br>+                    Reason => "Only effects some platforms");<br>+   procedure Initialize;<br>+   pragma Warnings (GNATprove, On, "subprogram ""Initialize"" has no effect");<br>+<br>    pragma Warnings (GNATprove, Off, "unused variable ""P*""",<br>                     Reason => "Needed for a common interface");<br>    procedure Pre_On<br>diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb<br>index 21b123d..1aecfab 100644<br>--- a/common/hw-gfx-gma.adb<br>+++ b/common/hw-gfx-gma.adb<br>@@ -364,6 +364,7 @@<br> <br>       Panel.Setup_PP_Sequencer;<br>       Port_Detect.Initialize;<br>+      Connectors.Initialize;<br> <br>       if Clean_State then<br>          Power_And_Clocks.Pre_All_Off;<br>diff --git a/common/ironlake/hw-gfx-gma-connectors.adb b/common/ironlake/hw-gfx-gma-connectors.adb<br>index 7d00fa6..8ae47fd 100644<br>--- a/common/ironlake/hw-gfx-gma-connectors.adb<br>+++ b/common/ironlake/hw-gfx-gma-connectors.adb<br>@@ -29,6 +29,12 @@<br> package body HW.GFX.GMA.Connectors<br> is<br> <br>+   procedure Initialize<br>+   is<br>+   begin<br>+      null;<br>+   end Initialize;<br>+<br>    function Is_Internal (Port_Cfg : Port_Config) return Boolean<br>    is<br>    begin<br></pre><p>To view, visit <a href="https://review.coreboot.org/20128">change 20128</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20128"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libgfxinit </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I62946152da9a93b881e0b0ea4b2679086ec8e970 </div>
<div style="display:none"> Gerrit-Change-Number: 20128 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>