[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake/chip.h: Provide enum values for SataMode

Nico Huber (Code Review) gerrit at coreboot.org
Tue Jul 25 16:35:05 CEST 2017


Nico Huber has uploaded this change for review. ( https://review.coreboot.org/20765


Change subject: soc/intel/skylake/chip.h: Provide enum values for SataMode
......................................................................

soc/intel/skylake/chip.h: Provide enum values for SataMode

The values were verified to be correct with the KabylakeFsp0001 from
github. Skylake FSP documentation disagrees so YMMV.

Change-Id: I1ee04dbbed48d5376dbc24ae70753b059f2646eb
Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
M src/soc/intel/skylake/chip.h
1 file changed, 7 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/20765/1

diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h
index 67a6783..cf64c8c 100644
--- a/src/soc/intel/skylake/chip.h
+++ b/src/soc/intel/skylake/chip.h
@@ -138,7 +138,13 @@
 
 	/* SATA related */
 	u8 EnableSata;
-	u8 SataMode;
+	enum {
+		/* Documentation and header files of Skylake FSP disagree on
+		   the values, Kaby Lake FSP (KabylakeFsp0001 on github) uses
+		   these: */
+		KBLFSP_SATA_MODE_AHCI    = 0,
+		KBLFSP_SATA_MODE_RAID    = 1,
+	} SataMode;
 	u8 SataSalpSupport;
 	u8 SataPortsEnable[8];
 	u8 SataPortsDevSlp[8];

-- 
To view, visit https://review.coreboot.org/20765
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ee04dbbed48d5376dbc24ae70753b059f2646eb
Gerrit-Change-Number: 20765
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170725/ec8bbed5/attachment.html>


More information about the coreboot-gerrit mailing list