<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20765">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/skylake/chip.h: Provide enum values for SataMode<br><br>The values were verified to be correct with the KabylakeFsp0001 from<br>github. Skylake FSP documentation disagrees so YMMV.<br><br>Change-Id: I1ee04dbbed48d5376dbc24ae70753b059f2646eb<br>Signed-off-by: Nico Huber <nico.huber@secunet.com><br>---<br>M src/soc/intel/skylake/chip.h<br>1 file changed, 7 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/20765/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h<br>index 67a6783..cf64c8c 100644<br>--- a/src/soc/intel/skylake/chip.h<br>+++ b/src/soc/intel/skylake/chip.h<br>@@ -138,7 +138,13 @@<br> <br>     /* SATA related */<br>    u8 EnableSata;<br>-       u8 SataMode;<br>+ enum {<br>+               /* Documentation and header files of Skylake FSP disagree on<br>+            the values, Kaby Lake FSP (KabylakeFsp0001 on github) uses<br>+                   these: */<br>+         KBLFSP_SATA_MODE_AHCI    = 0,<br>+                KBLFSP_SATA_MODE_RAID    = 1,<br>+        } SataMode;<br>   u8 SataSalpSupport;<br>   u8 SataPortsEnable[8];<br>        u8 SataPortsDevSlp[8];<br></pre><p>To view, visit <a href="https://review.coreboot.org/20765">change 20765</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20765"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I1ee04dbbed48d5376dbc24ae70753b059f2646eb </div>
<div style="display:none"> Gerrit-Change-Number: 20765 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>