[coreboot-gerrit] Change in coreboot[master]: src/cpu: Fix checkpatch warning: no spaces at the start of a line

Werner Zeh (Code Review) gerrit at coreboot.org
Mon Jul 24 07:14:08 CEST 2017


Werner Zeh has posted comments on this change. ( https://review.coreboot.org/20729 )

Change subject: src/cpu: Fix checkpatch warning: no spaces at the start of a line
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/20729/1/src/cpu/amd/agesa/family15/fixme.c
File src/cpu/amd/agesa/family15/fixme.c:

https://review.coreboot.org/#/c/20729/1/src/cpu/amd/agesa/family15/fixme.c@29
PS1, Line 29: 		 
Fix this indention as well?


https://review.coreboot.org/#/c/20729/1/src/cpu/amd/agesa/family15/fixme.c@44
PS1, Line 44: 		 
Fix this indention as well?


https://review.coreboot.org/#/c/20729/1/src/cpu/amd/family_10h-family_15h/fidvid.c
File src/cpu/amd/family_10h-family_15h/fidvid.c:

https://review.coreboot.org/#/c/20729/1/src/cpu/amd/family_10h-family_15h/fidvid.c@771
PS1, Line 771: 	   printk(BIOS_ERR,"F3xDC[PstateMaxVal] is zero. Northbridge voltage setting will fail. fixPsNbVidBeforeWR in fidvid.c needs fixing. See AMD # 31116 rev 3.48 BKDG 2.4.2.9.1\n");
Thats a long line...



-- 
To view, visit https://review.coreboot.org/20729
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabdaaaee49e8c5cead304cda66412aa36a2ffd19
Gerrit-Change-Number: 20729
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 24 Jul 2017 05:14:08 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170724/3680e101/attachment.html>


More information about the coreboot-gerrit mailing list