<p>Werner Zeh <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/20729">View Change</a></p><p>Patch set 1:</p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/20729/1/src/cpu/amd/agesa/family15/fixme.c">File src/cpu/amd/agesa/family15/fixme.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20729/1/src/cpu/amd/agesa/family15/fixme.c@29">Patch Set #1, Line 29:</a> <code style="font-family:monospace,monospace">             </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Fix this indention as well?</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20729/1/src/cpu/amd/agesa/family15/fixme.c@44">Patch Set #1, Line 44:</a> <code style="font-family:monospace,monospace">                </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Fix this indention as well?</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/20729/1/src/cpu/amd/family_10h-family_15h/fidvid.c">File src/cpu/amd/family_10h-family_15h/fidvid.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20729/1/src/cpu/amd/family_10h-family_15h/fidvid.c@771">Patch Set #1, Line 771:</a> <code style="font-family:monospace,monospace">    printk(BIOS_ERR,"F3xDC[PstateMaxVal] is zero. Northbridge voltage setting will fail. fixPsNbVidBeforeWR in fidvid.c needs fixing. See AMD # 31116 rev 3.48 BKDG 2.4.2.9.1\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Thats a long line...</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/20729">change 20729</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20729"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Iabdaaaee49e8c5cead304cda66412aa36a2ffd19 </div>
<div style="display:none"> Gerrit-Change-Number: 20729 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 24 Jul 2017 05:14:08 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>