[coreboot-gerrit] Change in coreboot[master]: src/drivers: Fix checkpatch warning: no spaces at the start of a line
Martin Roth (Code Review)
gerrit at coreboot.org
Mon Jul 24 04:15:19 CEST 2017
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/20731
Change subject: src/drivers: Fix checkpatch warning: no spaces at the start of a line
......................................................................
src/drivers: Fix checkpatch warning: no spaces at the start of a line
This excludes files which are mostly spaces, which I felt should be
handled separately.
Change-Id: I33043a3090e2fc6e9d2fd81e8a5e46fb6cb0aa35
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/drivers/aspeed/ast2050/ast2050.c
M src/drivers/ati/ragexl/fb.h
M src/drivers/ati/ragexl/mach64.h
M src/drivers/i2c/rtd2132/rtd2132.c
M src/drivers/ics/954309/ics954309.c
M src/drivers/intel/gma/i915.h
M src/drivers/ipmi/ipmi_kcs.c
M src/drivers/net/ne2k.c
M src/drivers/net/r8168.c
M src/drivers/pc80/tpm/tpm.c
M src/drivers/pc80/vga/vga.h
M src/drivers/sil/3114/sil_sata.c
M src/drivers/usb/ehci_debug.c
M src/drivers/usb/gadget.c
M src/drivers/usb/usb_ch9.h
M src/drivers/xgi/common/vstruct.h
M src/drivers/xgi/common/xgi_coreboot.h
M src/drivers/xgi/z9s/z9s.c
18 files changed, 101 insertions(+), 101 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/20731/1
diff --git a/src/drivers/aspeed/ast2050/ast2050.c b/src/drivers/aspeed/ast2050/ast2050.c
index 59d3f0b..ed128f3 100644
--- a/src/drivers/aspeed/ast2050/ast2050.c
+++ b/src/drivers/aspeed/ast2050/ast2050.c
@@ -73,7 +73,7 @@
};
static const struct pci_driver aspeed_ast2050_driver __pci_driver = {
- .ops = &aspeed_ast2050_ops,
- .vendor = PCI_VENDOR_ID_ASPEED,
- .device = PCI_DEVICE_ID_ASPEED_AST2050_VGA,
+ .ops = &aspeed_ast2050_ops,
+ .vendor = PCI_VENDOR_ID_ASPEED,
+ .device = PCI_DEVICE_ID_ASPEED_AST2050_VGA,
};
diff --git a/src/drivers/ati/ragexl/fb.h b/src/drivers/ati/ragexl/fb.h
index f112d0e..ebaf5b7 100644
--- a/src/drivers/ati/ragexl/fb.h
+++ b/src/drivers/ati/ragexl/fb.h
@@ -12,7 +12,7 @@
#define FB_MAX 32 /* sufficient for now */
/* ioctls
- 0x46 is 'F' */
+ 0x46 is 'F' */
#define FBIOGET_VSCREENINFO 0x4600
#define FBIOPUT_VSCREENINFO 0x4601
#define FBIOGET_FSCREENINFO 0x4602
@@ -271,9 +271,9 @@
- /*
- * Hardware Cursor
- */
+/*
+ * Hardware Cursor
+ */
#define FBIOGET_FCURSORINFO 0x4607
#define FBIOGET_VCURSORINFO 0x4608
@@ -307,38 +307,38 @@
struct fb_info {
- char modename[40]; /* default video mode */
+ char modename[40]; /* default video mode */
// kdev_t node;
- int flags;
- int open; /* Has this been open already ? */
- struct fb_var_screeninfo var; /* Current var */
+ int flags;
+ int open; /* Has this been open already ? */
+ struct fb_var_screeninfo var; /* Current var */
#if 0
- struct fb_fix_screeninfo fix; /* Current fix */
+ struct fb_fix_screeninfo fix; /* Current fix */
#endif
- struct fb_monspecs monspecs; /* Current Monitor specs */
- struct fb_cmap cmap; /* Current cmap */
+ struct fb_monspecs monspecs; /* Current Monitor specs */
+ struct fb_cmap cmap; /* Current cmap */
// struct fb_ops *fbops;
- char *screen_base; /* Virtual address */
- struct display *disp; /* initial display variable */
+ char *screen_base; /* Virtual address */
+ struct display *disp; /* initial display variable */
// struct vc_data *display_fg; /* Console visible on this display */
- char fontname[40]; /* default font name */
+ char fontname[40]; /* default font name */
#if 0
- devfs_handle_t devfs_handle; /* Devfs handle for new name */
- devfs_handle_t devfs_lhandle; /* Devfs handle for compat. symlink */
- int (*changevar)(int); /* tell console var has changed */
- int (*switch_con)(int, struct fb_info*);
+ devfs_handle_t devfs_handle; /* Devfs handle for new name */
+ devfs_handle_t devfs_lhandle; /* Devfs handle for compat. symlink */
+ int (*changevar)(int); /* tell console var has changed */
+ int (*switch_con)(int, struct fb_info*);
/* tell fb to switch consoles */
- int (*updatevar)(int, struct fb_info*);
+ int (*updatevar)(int, struct fb_info*);
/* tell fb to update the vars */
- void (*blank)(int, struct fb_info*); /* tell fb to (un)blank the screen */
+ void (*blank)(int, struct fb_info*); /* tell fb to (un)blank the screen */
/* arg = 0: unblank */
/* arg > 0: VESA level (arg-1) */
#endif
- void *pseudo_palette; /* Fake palette of 16 colors and
+ void *pseudo_palette; /* Fake palette of 16 colors and
the cursor's color for non
palette mode */
- /* From here on everything is device dependent */
- void *par;
+/* From here on everything is device dependent */
+ void *par;
};
#endif /* _LINUX_FB_H */
diff --git a/src/drivers/ati/ragexl/mach64.h b/src/drivers/ati/ragexl/mach64.h
index 354ae2b..7400b43 100644
--- a/src/drivers/ati/ragexl/mach64.h
+++ b/src/drivers/ati/ragexl/mach64.h
@@ -858,8 +858,8 @@
#define GL_CHIP_ID 0x474c /* RAGE XL, PQFP, PCI66 */
#define IS_XL(id) ((id)==GR_CHIP_ID || (id)==GS_CHIP_ID || \
- (id)==GM_CHIP_ID || (id)==GN_CHIP_ID || \
- (id)==GO_CHIP_ID || (id)==GL_CHIP_ID)
+ (id)==GM_CHIP_ID || (id)==GN_CHIP_ID || \
+ (id)==GO_CHIP_ID || (id)==GL_CHIP_ID)
#define GT_CHIP_ID 0x4754 /* RAGE (GT) */
#define GU_CHIP_ID 0x4755 /* RAGE II/II+ (GTB) */
diff --git a/src/drivers/i2c/rtd2132/rtd2132.c b/src/drivers/i2c/rtd2132/rtd2132.c
index a4c2756..2aaa234 100644
--- a/src/drivers/i2c/rtd2132/rtd2132.c
+++ b/src/drivers/i2c/rtd2132/rtd2132.c
@@ -149,7 +149,7 @@
}
static void rtd2132_lvds_swap(struct device *dev,
- struct drivers_i2c_rtd2132_config *cfg)
+ struct drivers_i2c_rtd2132_config *cfg)
{
u8 swap_value = RTD2132_LVDS_SWAP_NORMAL;
diff --git a/src/drivers/ics/954309/ics954309.c b/src/drivers/ics/954309/ics954309.c
index 5911609..a3d1d81 100644
--- a/src/drivers/ics/954309/ics954309.c
+++ b/src/drivers/ics/954309/ics954309.c
@@ -51,10 +51,10 @@
}
static struct device_operations ics954309_operations = {
- .read_resources = DEVICE_NOOP,
- .set_resources = DEVICE_NOOP,
- .enable_resources = DEVICE_NOOP,
- .init = ics954309_init,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
+ .init = ics954309_init,
};
static void enable_dev(struct device *dev)
diff --git a/src/drivers/intel/gma/i915.h b/src/drivers/intel/gma/i915.h
index 6f2b8ea..a4ae306 100644
--- a/src/drivers/intel/gma/i915.h
+++ b/src/drivers/intel/gma/i915.h
@@ -56,10 +56,10 @@
};
enum transcoder {
- TRANSCODER_A = 0,
- TRANSCODER_B,
- TRANSCODER_C,
- TRANSCODER_EDP = 0xF,
+ TRANSCODER_A = 0,
+ TRANSCODER_B,
+ TRANSCODER_C,
+ TRANSCODER_EDP = 0xF,
};
enum plane {
diff --git a/src/drivers/ipmi/ipmi_kcs.c b/src/drivers/ipmi/ipmi_kcs.c
index e6d2e0b..5ed46fe 100644
--- a/src/drivers/ipmi/ipmi_kcs.c
+++ b/src/drivers/ipmi/ipmi_kcs.c
@@ -85,7 +85,7 @@
if (wait_ibf_timeout(port))
return 1;
- status = ipmi_kcs_status(port);
+ status = ipmi_kcs_status(port);
if ((status & IPMI_KCS_OBF) &&
IPMI_KCS_STATE(status) != IPMI_KCS_STATE_WRITE) {
printk(BIOS_ERR, "%s: status %02x\n", __func__, status);
@@ -106,7 +106,7 @@
if (wait_ibf_timeout(port))
return 1;
- status = ipmi_kcs_status(port);
+ status = ipmi_kcs_status(port);
if ((status & IPMI_KCS_OBF) &&
IPMI_KCS_STATE(status) != IPMI_KCS_STATE_WRITE) {
printk(BIOS_ERR, "%s: status %02x\n", __func__, status);
diff --git a/src/drivers/net/ne2k.c b/src/drivers/net/ne2k.c
index ed56006..bec1d78 100644
--- a/src/drivers/net/ne2k.c
+++ b/src/drivers/net/ne2k.c
@@ -450,9 +450,9 @@
};
static const struct pci_driver ne2k_driver __pci_driver = {
- .ops = &ne2k_ops,
- .vendor = 0x10ec,
- .device = 0x8029,
+ .ops = &ne2k_ops,
+ .vendor = 0x10ec,
+ .device = 0x8029,
};
#endif /* __PRE_RAM__ */
diff --git a/src/drivers/net/r8168.c b/src/drivers/net/r8168.c
index f58a735..3727ccd 100644
--- a/src/drivers/net/r8168.c
+++ b/src/drivers/net/r8168.c
@@ -230,15 +230,15 @@
}
static struct device_operations r8168_ops = {
- .read_resources = pci_dev_read_resources,
- .set_resources = pci_dev_set_resources,
- .enable_resources = pci_dev_enable_resources,
- .init = r8168_init,
- .scan_bus = 0,
+ .read_resources = pci_dev_read_resources,
+ .set_resources = pci_dev_set_resources,
+ .enable_resources = pci_dev_enable_resources,
+ .init = r8168_init,
+ .scan_bus = 0,
};
static const struct pci_driver r8168_driver __pci_driver = {
- .ops = &r8168_ops,
- .vendor = 0x10ec,
- .device = 0x8168,
+ .ops = &r8168_ops,
+ .vendor = 0x10ec,
+ .device = 0x8168,
};
diff --git a/src/drivers/pc80/tpm/tpm.c b/src/drivers/pc80/tpm/tpm.c
index 0fdf548..e9730a9 100644
--- a/src/drivers/pc80/tpm/tpm.c
+++ b/src/drivers/pc80/tpm/tpm.c
@@ -58,7 +58,7 @@
/* the macro accepts the locality value, but only locality 0 is operational */
#define TIS_REG(LOCALITY, REG) \
- (void *)(CONFIG_TPM_TIS_BASE_ADDRESS + (LOCALITY << 12) + REG)
+ (void *)(CONFIG_TPM_TIS_BASE_ADDRESS + (LOCALITY << 12) + REG)
/* hardware registers' offsets */
#define TIS_REG_ACCESS 0x0
diff --git a/src/drivers/pc80/vga/vga.h b/src/drivers/pc80/vga/vga.h
index 1e6e750..a6fb2b4 100644
--- a/src/drivers/pc80/vga/vga.h
+++ b/src/drivers/pc80/vga/vga.h
@@ -5,9 +5,9 @@
* Basic palette.
*/
struct palette {
- unsigned char red;
- unsigned char green;
- unsigned char blue;
+ unsigned char red;
+ unsigned char green;
+ unsigned char blue;
};
extern const struct palette default_vga_palette[0x100];
diff --git a/src/drivers/sil/3114/sil_sata.c b/src/drivers/sil/3114/sil_sata.c
index 2510fa9..3c56266 100644
--- a/src/drivers/sil/3114/sil_sata.c
+++ b/src/drivers/sil/3114/sil_sata.c
@@ -51,9 +51,9 @@
};
static const struct pci_driver si_sata_driver __pci_driver = {
- .ops = &si_sata_ops,
- .vendor = 0x1095,
- .device = 0x3114,
+ .ops = &si_sata_ops,
+ .vendor = 0x1095,
+ .device = 0x3114,
};
static const struct pci_driver si_sata_driver_2 __pci_driver = {
diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c
index 6fcf683..9491a8f 100644
--- a/src/drivers/usb/ehci_debug.c
+++ b/src/drivers/usb/ehci_debug.c
@@ -455,10 +455,10 @@
dprintk(BIOS_INFO, "debug_port: %d\n", debug_port);
dprintk(BIOS_INFO, "n_ports: %d\n", n_ports);
- for (i = 1; i <= n_ports; i++) {
- portsc = read32(&ehci_regs->port_status[i-1]);
- dprintk(BIOS_INFO, "PORTSC #%d: %08x\n", i, portsc);
- }
+ for (i = 1; i <= n_ports; i++) {
+ portsc = read32(&ehci_regs->port_status[i-1]);
+ dprintk(BIOS_INFO, "PORTSC #%d: %08x\n", i, portsc);
+ }
if (port_map_tried && (new_debug_port != debug_port)) {
if (--playtimes) {
diff --git a/src/drivers/usb/gadget.c b/src/drivers/usb/gadget.c
index 7a1f073..ee18bd6 100644
--- a/src/drivers/usb/gadget.c
+++ b/src/drivers/usb/gadget.c
@@ -37,7 +37,7 @@
/* After USB port reset, treat device number 0 as an USB hub. Assign it with
* a device number hub_addr. Then apply enable and reset on downstream port.
*/
- static int dbgp_hub_enable(struct ehci_dbg_port *ehci_debug, unsigned char hub_addr,
+static int dbgp_hub_enable(struct ehci_dbg_port *ehci_debug, unsigned char hub_addr,
unsigned char port)
{
char status[8];
diff --git a/src/drivers/usb/usb_ch9.h b/src/drivers/usb/usb_ch9.h
index 271b7d1..d7f39dd 100644
--- a/src/drivers/usb/usb_ch9.h
+++ b/src/drivers/usb/usb_ch9.h
@@ -108,20 +108,20 @@
#define USB_PID_DATA_TOGGLE 0x88
struct usb_ctrlrequest {
- u8 bRequestType;
- u8 bRequest;
- u16 wValue;
- u16 wIndex;
- u16 wLength;
+ u8 bRequestType;
+ u8 bRequest;
+ u16 wValue;
+ u16 wIndex;
+ u16 wLength;
} __packed;
struct usb_debug_descriptor {
- u8 bLength;
- u8 bDescriptorType;
+ u8 bLength;
+ u8 bDescriptorType;
- /* bulk endpoints with 8 byte maxpacket */
- u8 bDebugInEndpoint;
- u8 bDebugOutEndpoint;
+ /* bulk endpoints with 8 byte maxpacket */
+ u8 bDebugInEndpoint;
+ u8 bDebugOutEndpoint;
};
#endif
diff --git a/src/drivers/xgi/common/vstruct.h b/src/drivers/xgi/common/vstruct.h
index 8172b9f..d14a182 100644
--- a/src/drivers/xgi/common/vstruct.h
+++ b/src/drivers/xgi/common/vstruct.h
@@ -50,7 +50,7 @@
#define _VSTRUCT_H_
struct SiS_PanelDelayTbl {
- unsigned char timer[2];
+ unsigned char timer[2];
};
struct SiS_LCDData {
@@ -166,7 +166,7 @@
};
struct SiS_Part2PortTbl {
- unsigned char CR[12];
+ unsigned char CR[12];
};
struct SiS_CRT1Table {
diff --git a/src/drivers/xgi/common/xgi_coreboot.h b/src/drivers/xgi/common/xgi_coreboot.h
index dd51782..b9332e8 100644
--- a/src/drivers/xgi/common/xgi_coreboot.h
+++ b/src/drivers/xgi/common/xgi_coreboot.h
@@ -176,30 +176,30 @@
#define VB_VIDEOBRIDGE (VB_SISBRIDGE | VB_LVDS | VB_CHRONTEL | VB_CONEXANT)
enum _SIS_LCD_TYPE {
- LCD_INVALID = 0,
- LCD_800x600,
- LCD_1024x768,
- LCD_1280x1024,
- LCD_1280x960,
- LCD_640x480,
- LCD_1600x1200,
- LCD_1920x1440,
- LCD_2048x1536,
- LCD_320x240, /* FSTN */
- LCD_1400x1050,
- LCD_1152x864,
- LCD_1152x768,
- LCD_1280x768,
- LCD_1024x600,
- LCD_320x240_2, /* DSTN */
- LCD_320x240_3, /* DSTN */
- LCD_848x480,
- LCD_1280x800,
- LCD_1680x1050,
- LCD_1280x720,
- LCD_1280x854,
- LCD_CUSTOM,
- LCD_UNKNOWN
+ LCD_INVALID = 0,
+ LCD_800x600,
+ LCD_1024x768,
+ LCD_1280x1024,
+ LCD_1280x960,
+ LCD_640x480,
+ LCD_1600x1200,
+ LCD_1920x1440,
+ LCD_2048x1536,
+ LCD_320x240, /* FSTN */
+ LCD_1400x1050,
+ LCD_1152x864,
+ LCD_1152x768,
+ LCD_1280x768,
+ LCD_1024x600,
+ LCD_320x240_2, /* DSTN */
+ LCD_320x240_3, /* DSTN */
+ LCD_848x480,
+ LCD_1280x800,
+ LCD_1680x1050,
+ LCD_1280x720,
+ LCD_1280x854,
+ LCD_CUSTOM,
+ LCD_UNKNOWN
};
/* End code taken from Linux kernel 3.18.5 */
diff --git a/src/drivers/xgi/z9s/z9s.c b/src/drivers/xgi/z9s/z9s.c
index 4c1e44a..dc4fd3c 100644
--- a/src/drivers/xgi/z9s/z9s.c
+++ b/src/drivers/xgi/z9s/z9s.c
@@ -59,7 +59,7 @@
};
static const struct pci_driver xgi_z9s_driver __pci_driver = {
- .ops = &xgi_z9s_ops,
- .vendor = PCI_VENDOR_ID_XGI,
- .device = PCI_DEVICE_ID_XGI_20,
+ .ops = &xgi_z9s_ops,
+ .vendor = PCI_VENDOR_ID_XGI,
+ .device = PCI_DEVICE_ID_XGI_20,
};
--
To view, visit https://review.coreboot.org/20731
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33043a3090e2fc6e9d2fd81e8a5e46fb6cb0aa35
Gerrit-Change-Number: 20731
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170724/95828d03/attachment-0001.html>
More information about the coreboot-gerrit
mailing list