<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20731">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/drivers: Fix checkpatch warning: no spaces at the start of a line<br><br>This excludes files which are mostly spaces, which I felt should be<br>handled separately.<br><br>Change-Id: I33043a3090e2fc6e9d2fd81e8a5e46fb6cb0aa35<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M src/drivers/aspeed/ast2050/ast2050.c<br>M src/drivers/ati/ragexl/fb.h<br>M src/drivers/ati/ragexl/mach64.h<br>M src/drivers/i2c/rtd2132/rtd2132.c<br>M src/drivers/ics/954309/ics954309.c<br>M src/drivers/intel/gma/i915.h<br>M src/drivers/ipmi/ipmi_kcs.c<br>M src/drivers/net/ne2k.c<br>M src/drivers/net/r8168.c<br>M src/drivers/pc80/tpm/tpm.c<br>M src/drivers/pc80/vga/vga.h<br>M src/drivers/sil/3114/sil_sata.c<br>M src/drivers/usb/ehci_debug.c<br>M src/drivers/usb/gadget.c<br>M src/drivers/usb/usb_ch9.h<br>M src/drivers/xgi/common/vstruct.h<br>M src/drivers/xgi/common/xgi_coreboot.h<br>M src/drivers/xgi/z9s/z9s.c<br>18 files changed, 101 insertions(+), 101 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/20731/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/drivers/aspeed/ast2050/ast2050.c b/src/drivers/aspeed/ast2050/ast2050.c<br>index 59d3f0b..ed128f3 100644<br>--- a/src/drivers/aspeed/ast2050/ast2050.c<br>+++ b/src/drivers/aspeed/ast2050/ast2050.c<br>@@ -73,7 +73,7 @@<br> };<br> <br> static const struct pci_driver aspeed_ast2050_driver __pci_driver = {<br>- .ops = &aspeed_ast2050_ops,<br>- .vendor = PCI_VENDOR_ID_ASPEED,<br>- .device = PCI_DEVICE_ID_ASPEED_AST2050_VGA,<br>+ .ops = &aspeed_ast2050_ops,<br>+ .vendor = PCI_VENDOR_ID_ASPEED,<br>+ .device = PCI_DEVICE_ID_ASPEED_AST2050_VGA,<br> };<br>diff --git a/src/drivers/ati/ragexl/fb.h b/src/drivers/ati/ragexl/fb.h<br>index f112d0e..ebaf5b7 100644<br>--- a/src/drivers/ati/ragexl/fb.h<br>+++ b/src/drivers/ati/ragexl/fb.h<br>@@ -12,7 +12,7 @@<br> #define FB_MAX 32 /* sufficient for now */<br> <br> /* ioctls<br>- 0x46 is 'F' */<br>+ 0x46 is 'F' */<br> #define FBIOGET_VSCREENINFO 0x4600<br> #define FBIOPUT_VSCREENINFO 0x4601<br> #define FBIOGET_FSCREENINFO 0x4602<br>@@ -271,9 +271,9 @@<br> <br> <br> <br>- /*<br>- * Hardware Cursor<br>- */<br>+/*<br>+ * Hardware Cursor<br>+ */<br> <br> #define FBIOGET_FCURSORINFO 0x4607<br> #define FBIOGET_VCURSORINFO 0x4608<br>@@ -307,38 +307,38 @@<br> <br> <br> struct fb_info {<br>- char modename[40]; /* default video mode */<br>+ char modename[40]; /* default video mode */<br> // kdev_t node;<br>- int flags;<br>- int open; /* Has this been open already ? */<br>- struct fb_var_screeninfo var; /* Current var */<br>+ int flags;<br>+ int open; /* Has this been open already ? */<br>+ struct fb_var_screeninfo var; /* Current var */<br> #if 0<br>- struct fb_fix_screeninfo fix; /* Current fix */<br>+ struct fb_fix_screeninfo fix; /* Current fix */<br> #endif<br>- struct fb_monspecs monspecs; /* Current Monitor specs */<br>- struct fb_cmap cmap; /* Current cmap */<br>+ struct fb_monspecs monspecs; /* Current Monitor specs */<br>+ struct fb_cmap cmap; /* Current cmap */<br> // struct fb_ops *fbops;<br>- char *screen_base; /* Virtual address */<br>- struct display *disp; /* initial display variable */<br>+ char *screen_base; /* Virtual address */<br>+ struct display *disp; /* initial display variable */<br> // struct vc_data *display_fg; /* Console visible on this display */<br>- char fontname[40]; /* default font name */<br>+ char fontname[40]; /* default font name */<br> #if 0<br>- devfs_handle_t devfs_handle; /* Devfs handle for new name */<br>- devfs_handle_t devfs_lhandle; /* Devfs handle for compat. symlink */<br>- int (*changevar)(int); /* tell console var has changed */<br>- int (*switch_con)(int, struct fb_info*);<br>+ devfs_handle_t devfs_handle; /* Devfs handle for new name */<br>+ devfs_handle_t devfs_lhandle; /* Devfs handle for compat. symlink */<br>+ int (*changevar)(int); /* tell console var has changed */<br>+ int (*switch_con)(int, struct fb_info*);<br> /* tell fb to switch consoles */<br>- int (*updatevar)(int, struct fb_info*);<br>+ int (*updatevar)(int, struct fb_info*);<br> /* tell fb to update the vars */<br>- void (*blank)(int, struct fb_info*); /* tell fb to (un)blank the screen */<br>+ void (*blank)(int, struct fb_info*); /* tell fb to (un)blank the screen */<br> /* arg = 0: unblank */<br> /* arg > 0: VESA level (arg-1) */<br> #endif<br>- void *pseudo_palette; /* Fake palette of 16 colors and<br>+ void *pseudo_palette; /* Fake palette of 16 colors and<br> the cursor's color for non<br> palette mode */<br>- /* From here on everything is device dependent */<br>- void *par;<br>+/* From here on everything is device dependent */<br>+ void *par;<br> };<br> <br> #endif /* _LINUX_FB_H */<br>diff --git a/src/drivers/ati/ragexl/mach64.h b/src/drivers/ati/ragexl/mach64.h<br>index 354ae2b..7400b43 100644<br>--- a/src/drivers/ati/ragexl/mach64.h<br>+++ b/src/drivers/ati/ragexl/mach64.h<br>@@ -858,8 +858,8 @@<br> #define GL_CHIP_ID 0x474c /* RAGE XL, PQFP, PCI66 */<br> <br> #define IS_XL(id) ((id)==GR_CHIP_ID || (id)==GS_CHIP_ID || \<br>- (id)==GM_CHIP_ID || (id)==GN_CHIP_ID || \<br>- (id)==GO_CHIP_ID || (id)==GL_CHIP_ID)<br>+ (id)==GM_CHIP_ID || (id)==GN_CHIP_ID || \<br>+ (id)==GO_CHIP_ID || (id)==GL_CHIP_ID)<br> <br> #define GT_CHIP_ID 0x4754 /* RAGE (GT) */<br> #define GU_CHIP_ID 0x4755 /* RAGE II/II+ (GTB) */<br>diff --git a/src/drivers/i2c/rtd2132/rtd2132.c b/src/drivers/i2c/rtd2132/rtd2132.c<br>index a4c2756..2aaa234 100644<br>--- a/src/drivers/i2c/rtd2132/rtd2132.c<br>+++ b/src/drivers/i2c/rtd2132/rtd2132.c<br>@@ -149,7 +149,7 @@<br> }<br> <br> static void rtd2132_lvds_swap(struct device *dev,<br>- struct drivers_i2c_rtd2132_config *cfg)<br>+ struct drivers_i2c_rtd2132_config *cfg)<br> {<br> u8 swap_value = RTD2132_LVDS_SWAP_NORMAL;<br> <br>diff --git a/src/drivers/ics/954309/ics954309.c b/src/drivers/ics/954309/ics954309.c<br>index 5911609..a3d1d81 100644<br>--- a/src/drivers/ics/954309/ics954309.c<br>+++ b/src/drivers/ics/954309/ics954309.c<br>@@ -51,10 +51,10 @@<br> }<br> <br> static struct device_operations ics954309_operations = {<br>- .read_resources = DEVICE_NOOP,<br>- .set_resources = DEVICE_NOOP,<br>- .enable_resources = DEVICE_NOOP,<br>- .init = ics954309_init,<br>+ .read_resources = DEVICE_NOOP,<br>+ .set_resources = DEVICE_NOOP,<br>+ .enable_resources = DEVICE_NOOP,<br>+ .init = ics954309_init,<br> };<br> <br> static void enable_dev(struct device *dev)<br>diff --git a/src/drivers/intel/gma/i915.h b/src/drivers/intel/gma/i915.h<br>index 6f2b8ea..a4ae306 100644<br>--- a/src/drivers/intel/gma/i915.h<br>+++ b/src/drivers/intel/gma/i915.h<br>@@ -56,10 +56,10 @@<br> };<br> <br> enum transcoder {<br>- TRANSCODER_A = 0,<br>- TRANSCODER_B,<br>- TRANSCODER_C,<br>- TRANSCODER_EDP = 0xF,<br>+ TRANSCODER_A = 0,<br>+ TRANSCODER_B,<br>+ TRANSCODER_C,<br>+ TRANSCODER_EDP = 0xF,<br> };<br> <br> enum plane {<br>diff --git a/src/drivers/ipmi/ipmi_kcs.c b/src/drivers/ipmi/ipmi_kcs.c<br>index e6d2e0b..5ed46fe 100644<br>--- a/src/drivers/ipmi/ipmi_kcs.c<br>+++ b/src/drivers/ipmi/ipmi_kcs.c<br>@@ -85,7 +85,7 @@<br> if (wait_ibf_timeout(port))<br> return 1;<br> <br>- status = ipmi_kcs_status(port);<br>+ status = ipmi_kcs_status(port);<br> if ((status & IPMI_KCS_OBF) &&<br> IPMI_KCS_STATE(status) != IPMI_KCS_STATE_WRITE) {<br> printk(BIOS_ERR, "%s: status %02x\n", __func__, status);<br>@@ -106,7 +106,7 @@<br> if (wait_ibf_timeout(port))<br> return 1;<br> <br>- status = ipmi_kcs_status(port);<br>+ status = ipmi_kcs_status(port);<br> if ((status & IPMI_KCS_OBF) &&<br> IPMI_KCS_STATE(status) != IPMI_KCS_STATE_WRITE) {<br> printk(BIOS_ERR, "%s: status %02x\n", __func__, status);<br>diff --git a/src/drivers/net/ne2k.c b/src/drivers/net/ne2k.c<br>index ed56006..bec1d78 100644<br>--- a/src/drivers/net/ne2k.c<br>+++ b/src/drivers/net/ne2k.c<br>@@ -450,9 +450,9 @@<br> };<br> <br> static const struct pci_driver ne2k_driver __pci_driver = {<br>- .ops = &ne2k_ops,<br>- .vendor = 0x10ec,<br>- .device = 0x8029,<br>+ .ops = &ne2k_ops,<br>+ .vendor = 0x10ec,<br>+ .device = 0x8029,<br> };<br> <br> #endif /* __PRE_RAM__ */<br>diff --git a/src/drivers/net/r8168.c b/src/drivers/net/r8168.c<br>index f58a735..3727ccd 100644<br>--- a/src/drivers/net/r8168.c<br>+++ b/src/drivers/net/r8168.c<br>@@ -230,15 +230,15 @@<br> }<br> <br> static struct device_operations r8168_ops = {<br>- .read_resources = pci_dev_read_resources,<br>- .set_resources = pci_dev_set_resources,<br>- .enable_resources = pci_dev_enable_resources,<br>- .init = r8168_init,<br>- .scan_bus = 0,<br>+ .read_resources = pci_dev_read_resources,<br>+ .set_resources = pci_dev_set_resources,<br>+ .enable_resources = pci_dev_enable_resources,<br>+ .init = r8168_init,<br>+ .scan_bus = 0,<br> };<br> <br> static const struct pci_driver r8168_driver __pci_driver = {<br>- .ops = &r8168_ops,<br>- .vendor = 0x10ec,<br>- .device = 0x8168,<br>+ .ops = &r8168_ops,<br>+ .vendor = 0x10ec,<br>+ .device = 0x8168,<br> };<br>diff --git a/src/drivers/pc80/tpm/tpm.c b/src/drivers/pc80/tpm/tpm.c<br>index 0fdf548..e9730a9 100644<br>--- a/src/drivers/pc80/tpm/tpm.c<br>+++ b/src/drivers/pc80/tpm/tpm.c<br>@@ -58,7 +58,7 @@<br> <br> /* the macro accepts the locality value, but only locality 0 is operational */<br> #define TIS_REG(LOCALITY, REG) \<br>- (void *)(CONFIG_TPM_TIS_BASE_ADDRESS + (LOCALITY << 12) + REG)<br>+ (void *)(CONFIG_TPM_TIS_BASE_ADDRESS + (LOCALITY << 12) + REG)<br> <br> /* hardware registers' offsets */<br> #define TIS_REG_ACCESS 0x0<br>diff --git a/src/drivers/pc80/vga/vga.h b/src/drivers/pc80/vga/vga.h<br>index 1e6e750..a6fb2b4 100644<br>--- a/src/drivers/pc80/vga/vga.h<br>+++ b/src/drivers/pc80/vga/vga.h<br>@@ -5,9 +5,9 @@<br> * Basic palette.<br> */<br> struct palette {<br>- unsigned char red;<br>- unsigned char green;<br>- unsigned char blue;<br>+ unsigned char red;<br>+ unsigned char green;<br>+ unsigned char blue;<br> };<br> <br> extern const struct palette default_vga_palette[0x100];<br>diff --git a/src/drivers/sil/3114/sil_sata.c b/src/drivers/sil/3114/sil_sata.c<br>index 2510fa9..3c56266 100644<br>--- a/src/drivers/sil/3114/sil_sata.c<br>+++ b/src/drivers/sil/3114/sil_sata.c<br>@@ -51,9 +51,9 @@<br> };<br> <br> static const struct pci_driver si_sata_driver __pci_driver = {<br>- .ops = &si_sata_ops,<br>- .vendor = 0x1095,<br>- .device = 0x3114,<br>+ .ops = &si_sata_ops,<br>+ .vendor = 0x1095,<br>+ .device = 0x3114,<br> };<br> <br> static const struct pci_driver si_sata_driver_2 __pci_driver = {<br>diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c<br>index 6fcf683..9491a8f 100644<br>--- a/src/drivers/usb/ehci_debug.c<br>+++ b/src/drivers/usb/ehci_debug.c<br>@@ -455,10 +455,10 @@<br> dprintk(BIOS_INFO, "debug_port: %d\n", debug_port);<br> dprintk(BIOS_INFO, "n_ports: %d\n", n_ports);<br> <br>- for (i = 1; i <= n_ports; i++) {<br>- portsc = read32(&ehci_regs->port_status[i-1]);<br>- dprintk(BIOS_INFO, "PORTSC #%d: %08x\n", i, portsc);<br>- }<br>+ for (i = 1; i <= n_ports; i++) {<br>+ portsc = read32(&ehci_regs->port_status[i-1]);<br>+ dprintk(BIOS_INFO, "PORTSC #%d: %08x\n", i, portsc);<br>+ }<br> <br> if (port_map_tried && (new_debug_port != debug_port)) {<br> if (--playtimes) {<br>diff --git a/src/drivers/usb/gadget.c b/src/drivers/usb/gadget.c<br>index 7a1f073..ee18bd6 100644<br>--- a/src/drivers/usb/gadget.c<br>+++ b/src/drivers/usb/gadget.c<br>@@ -37,7 +37,7 @@<br> /* After USB port reset, treat device number 0 as an USB hub. Assign it with<br> * a device number hub_addr. Then apply enable and reset on downstream port.<br> */<br>- static int dbgp_hub_enable(struct ehci_dbg_port *ehci_debug, unsigned char hub_addr,<br>+static int dbgp_hub_enable(struct ehci_dbg_port *ehci_debug, unsigned char hub_addr,<br> unsigned char port)<br> {<br> char status[8];<br>diff --git a/src/drivers/usb/usb_ch9.h b/src/drivers/usb/usb_ch9.h<br>index 271b7d1..d7f39dd 100644<br>--- a/src/drivers/usb/usb_ch9.h<br>+++ b/src/drivers/usb/usb_ch9.h<br>@@ -108,20 +108,20 @@<br> #define USB_PID_DATA_TOGGLE 0x88<br> <br> struct usb_ctrlrequest {<br>- u8 bRequestType;<br>- u8 bRequest;<br>- u16 wValue;<br>- u16 wIndex;<br>- u16 wLength;<br>+ u8 bRequestType;<br>+ u8 bRequest;<br>+ u16 wValue;<br>+ u16 wIndex;<br>+ u16 wLength;<br> } __packed;<br> <br> struct usb_debug_descriptor {<br>- u8 bLength;<br>- u8 bDescriptorType;<br>+ u8 bLength;<br>+ u8 bDescriptorType;<br> <br>- /* bulk endpoints with 8 byte maxpacket */<br>- u8 bDebugInEndpoint;<br>- u8 bDebugOutEndpoint;<br>+ /* bulk endpoints with 8 byte maxpacket */<br>+ u8 bDebugInEndpoint;<br>+ u8 bDebugOutEndpoint;<br> };<br> <br> #endif<br>diff --git a/src/drivers/xgi/common/vstruct.h b/src/drivers/xgi/common/vstruct.h<br>index 8172b9f..d14a182 100644<br>--- a/src/drivers/xgi/common/vstruct.h<br>+++ b/src/drivers/xgi/common/vstruct.h<br>@@ -50,7 +50,7 @@<br> #define _VSTRUCT_H_<br> <br> struct SiS_PanelDelayTbl {<br>- unsigned char timer[2];<br>+ unsigned char timer[2];<br> };<br> <br> struct SiS_LCDData {<br>@@ -166,7 +166,7 @@<br> };<br> <br> struct SiS_Part2PortTbl {<br>- unsigned char CR[12];<br>+ unsigned char CR[12];<br> };<br> <br> struct SiS_CRT1Table {<br>diff --git a/src/drivers/xgi/common/xgi_coreboot.h b/src/drivers/xgi/common/xgi_coreboot.h<br>index dd51782..b9332e8 100644<br>--- a/src/drivers/xgi/common/xgi_coreboot.h<br>+++ b/src/drivers/xgi/common/xgi_coreboot.h<br>@@ -176,30 +176,30 @@<br> #define VB_VIDEOBRIDGE (VB_SISBRIDGE | VB_LVDS | VB_CHRONTEL | VB_CONEXANT)<br> <br> enum _SIS_LCD_TYPE {<br>- LCD_INVALID = 0,<br>- LCD_800x600,<br>- LCD_1024x768,<br>- LCD_1280x1024,<br>- LCD_1280x960,<br>- LCD_640x480,<br>- LCD_1600x1200,<br>- LCD_1920x1440,<br>- LCD_2048x1536,<br>- LCD_320x240, /* FSTN */<br>- LCD_1400x1050,<br>- LCD_1152x864,<br>- LCD_1152x768,<br>- LCD_1280x768,<br>- LCD_1024x600,<br>- LCD_320x240_2, /* DSTN */<br>- LCD_320x240_3, /* DSTN */<br>- LCD_848x480,<br>- LCD_1280x800,<br>- LCD_1680x1050,<br>- LCD_1280x720,<br>- LCD_1280x854,<br>- LCD_CUSTOM,<br>- LCD_UNKNOWN<br>+ LCD_INVALID = 0,<br>+ LCD_800x600,<br>+ LCD_1024x768,<br>+ LCD_1280x1024,<br>+ LCD_1280x960,<br>+ LCD_640x480,<br>+ LCD_1600x1200,<br>+ LCD_1920x1440,<br>+ LCD_2048x1536,<br>+ LCD_320x240, /* FSTN */<br>+ LCD_1400x1050,<br>+ LCD_1152x864,<br>+ LCD_1152x768,<br>+ LCD_1280x768,<br>+ LCD_1024x600,<br>+ LCD_320x240_2, /* DSTN */<br>+ LCD_320x240_3, /* DSTN */<br>+ LCD_848x480,<br>+ LCD_1280x800,<br>+ LCD_1680x1050,<br>+ LCD_1280x720,<br>+ LCD_1280x854,<br>+ LCD_CUSTOM,<br>+ LCD_UNKNOWN<br> };<br> <br> /* End code taken from Linux kernel 3.18.5 */<br>diff --git a/src/drivers/xgi/z9s/z9s.c b/src/drivers/xgi/z9s/z9s.c<br>index 4c1e44a..dc4fd3c 100644<br>--- a/src/drivers/xgi/z9s/z9s.c<br>+++ b/src/drivers/xgi/z9s/z9s.c<br>@@ -59,7 +59,7 @@<br> };<br> <br> static const struct pci_driver xgi_z9s_driver __pci_driver = {<br>- .ops = &xgi_z9s_ops,<br>- .vendor = PCI_VENDOR_ID_XGI,<br>- .device = PCI_DEVICE_ID_XGI_20,<br>+ .ops = &xgi_z9s_ops,<br>+ .vendor = PCI_VENDOR_ID_XGI,<br>+ .device = PCI_DEVICE_ID_XGI_20,<br> };<br></pre><p>To view, visit <a href="https://review.coreboot.org/20731">change 20731</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20731"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I33043a3090e2fc6e9d2fd81e8a5e46fb6cb0aa35 </div>
<div style="display:none"> Gerrit-Change-Number: 20731 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>