[coreboot-gerrit] Change in coreboot[master]: 440BX boards: Drop unused #includes from romstage

Martin Roth (Code Review) gerrit at coreboot.org
Sun Jul 23 22:22:30 CEST 2017 

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/20693 )

Change subject: 440BX boards: Drop unused #includes from romstage
......................................................................

440BX boards: Drop unused #includes from romstage

Romstage of many 440BX boards included headers that are not used.
Remove them as part of a bigger cleanup effort.

Change-Id: I89ddeda3c90e1a4907c05851185b69f3b29e54ba
Signed-off-by: Keith Hui <buurin at gmail.com>
Reviewed-on: https://review.coreboot.org/20693
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/a-trend/atc-6220/romstage.c
M src/mainboard/a-trend/atc-6240/romstage.c
M src/mainboard/asus/p2b-ds/romstage.c
M src/mainboard/asus/p2b-ls/romstage.c
M src/mainboard/asus/p2b/romstage.c
M src/mainboard/asus/p3b-f/romstage.c
M src/mainboard/azza/pt-6ibd/romstage.c
M src/mainboard/gigabyte/ga-6bxc/romstage.c
M src/mainboard/gigabyte/ga-6bxe/romstage.c
M src/mainboard/msi/ms6119/romstage.c
M src/mainboard/msi/ms6147/romstage.c
M src/mainboard/msi/ms6156/romstage.c
M src/mainboard/nokia/ip530/romstage.c
M src/mainboard/soyo/sy-6ba-plus-iii/romstage.c
M src/mainboard/tyan/s1846/romstage.c
15 files changed, 0 insertions(+), 55 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved



diff --git a/src/mainboard/a-trend/atc-6220/romstage.c b/src/mainboard/a-trend/atc-6220/romstage.c
index 09e0183..6cf86c1 100644
--- a/src/mainboard/a-trend/atc-6220/romstage.c
+++ b/src/mainboard/a-trend/atc-6220/romstage.c
@@ -14,20 +14,15 @@
  * GNU General Public License for more details.
  */
 
-#include <stdint.h>
 #include <device/pci_def.h>
-#include <arch/io.h>
 #include <device/pnp_def.h>
-#include <stdlib.h>
 #include <console/console.h>
 #include <southbridge/intel/i82371eb/i82371eb.h>
 #include <northbridge/intel/i440bx/raminit.h>
-#include <delay.h>
 #include <cpu/x86/bist.h>
 #include <cpu/intel/romstage.h>
 #include <superio/winbond/common/winbond.h>
 #include <superio/winbond/w83977tf/w83977tf.h>
-
 #include <lib.h>
 
 #define SERIAL_DEV PNP_DEV(0x3f0, W83977TF_SP1)
diff --git a/src/mainboard/a-trend/atc-6240/romstage.c b/src/mainboard/a-trend/atc-6240/romstage.c
index 11ce41b..cbb0207 100644
--- a/src/mainboard/a-trend/atc-6240/romstage.c
+++ b/src/mainboard/a-trend/atc-6240/romstage.c
@@ -14,15 +14,11 @@
  * GNU General Public License for more details.
  */
 
-#include <stdint.h>
-#include <stdlib.h>
 #include <device/pci_def.h>
-#include <arch/io.h>
 #include <device/pnp_def.h>
 #include <console/console.h>
 #include <southbridge/intel/i82371eb/i82371eb.h>
 #include <northbridge/intel/i440bx/raminit.h>
-#include <delay.h>
 #include <cpu/x86/bist.h>
 #include <cpu/intel/romstage.h>
 #include <superio/winbond/common/winbond.h>
diff --git a/src/mainboard/asus/p2b-ds/romstage.c b/src/mainboard/asus/p2b-ds/romstage.c
index 694f03e..809f1f6 100644
--- a/src/mainboard/asus/p2b-ds/romstage.c
+++ b/src/mainboard/asus/p2b-ds/romstage.c
@@ -14,15 +14,11 @@
  * GNU General Public License for more details.
  */
 
-#include <stdint.h>
 #include <device/pci_def.h>
-#include <arch/io.h>
 #include <device/pnp_def.h>
-#include <stdlib.h>
 #include <console/console.h>
 #include <southbridge/intel/i82371eb/i82371eb.h>
 #include <northbridge/intel/i440bx/raminit.h>
-#include <delay.h>
 #include <cpu/x86/bist.h>
 #include <cpu/intel/romstage.h>
 #include <superio/winbond/common/winbond.h>
diff --git a/src/mainboard/asus/p2b-ls/romstage.c b/src/mainboard/asus/p2b-ls/romstage.c
index acd15f7..5ed878f 100644
--- a/src/mainboard/asus/p2b-ls/romstage.c
+++ b/src/mainboard/asus/p2b-ls/romstage.c
@@ -14,15 +14,11 @@
  * GNU General Public License for more details.
  */
 
-#include <stdint.h>
 #include <device/pci_def.h>
-#include <arch/io.h>
 #include <device/pnp_def.h>
-#include <stdlib.h>
 #include <console/console.h>
 #include <southbridge/intel/i82371eb/i82371eb.h>
 #include <northbridge/intel/i440bx/raminit.h>
-#include <delay.h>
 #include <cpu/x86/bist.h>
 #include <cpu/intel/romstage.h>
 #include <superio/winbond/common/winbond.h>
diff --git a/src/mainboard/asus/p2b/romstage.c b/src/mainboard/asus/p2b/romstage.c
index 09e0183..6cf86c1 100644
--- a/src/mainboard/asus/p2b/romstage.c
+++ b/src/mainboard/asus/p2b/romstage.c
@@ -14,20 +14,15 @@
  * GNU General Public License for more details.
  */
 
-#include <stdint.h>
 #include <device/pci_def.h>
-#include <arch/io.h>
 #include <device/pnp_def.h>
-#include <stdlib.h>
 #include <console/console.h>
 #include <southbridge/intel/i82371eb/i82371eb.h>
 #include <northbridge/intel/i440bx/raminit.h>
-#include <delay.h>
 #include <cpu/x86/bist.h>
 #include <cpu/intel/romstage.h>
 #include <superio/winbond/common/winbond.h>
 #include <superio/winbond/w83977tf/w83977tf.h>
-
 #include <lib.h>
 
 #define SERIAL_DEV PNP_DEV(0x3f0, W83977TF_SP1)
diff --git a/src/mainboard/asus/p3b-f/romstage.c b/src/mainboard/asus/p3b-f/romstage.c
index 9d56d5b..bb16c78 100644
--- a/src/mainboard/asus/p3b-f/romstage.c
+++ b/src/mainboard/asus/p3b-f/romstage.c
@@ -14,15 +14,11 @@
  * GNU General Public License for more details.
  */
 
-#include <stdint.h>
 #include <device/pci_def.h>
-#include <arch/io.h>
 #include <device/pnp_def.h>
-#include <stdlib.h>
 #include <console/console.h>
 #include <southbridge/intel/i82371eb/i82371eb.h>
 #include <northbridge/intel/i440bx/raminit.h>
-#include <delay.h>
 #include <cpu/x86/bist.h>
 #include <cpu/intel/romstage.h>
 #include <superio/winbond/common/winbond.h>
diff --git a/src/mainboard/azza/pt-6ibd/romstage.c b/src/mainboard/azza/pt-6ibd/romstage.c
index a9960db..c4cfbec 100644
--- a/src/mainboard/azza/pt-6ibd/romstage.c
+++ b/src/mainboard/azza/pt-6ibd/romstage.c
@@ -16,13 +16,10 @@
 
 #include <stdint.h>
 #include <device/pci_def.h>
-#include <arch/io.h>
 #include <device/pnp_def.h>
-#include <stdlib.h>
 #include <console/console.h>
 #include <southbridge/intel/i82371eb/i82371eb.h>
 #include <northbridge/intel/i440bx/raminit.h>
-#include <delay.h>
 #include <cpu/x86/bist.h>
 #include <cpu/intel/romstage.h>
 #include <superio/winbond/common/winbond.h>
diff --git a/src/mainboard/gigabyte/ga-6bxc/romstage.c b/src/mainboard/gigabyte/ga-6bxc/romstage.c
index 25e00c4..425a615 100644
--- a/src/mainboard/gigabyte/ga-6bxc/romstage.c
+++ b/src/mainboard/gigabyte/ga-6bxc/romstage.c
@@ -16,13 +16,10 @@
 
 #include <stdint.h>
 #include <device/pci_def.h>
-#include <arch/io.h>
 #include <device/pnp_def.h>
-#include <stdlib.h>
 #include <console/console.h>
 #include <southbridge/intel/i82371eb/i82371eb.h>
 #include <northbridge/intel/i440bx/raminit.h>
-#include <delay.h>
 #include <cpu/x86/bist.h>
 #include <cpu/intel/romstage.h>
 #include <superio/ite/it8671f/it8671f.h>
diff --git a/src/mainboard/gigabyte/ga-6bxe/romstage.c b/src/mainboard/gigabyte/ga-6bxe/romstage.c
index e49e50c..85b36b9 100644
--- a/src/mainboard/gigabyte/ga-6bxe/romstage.c
+++ b/src/mainboard/gigabyte/ga-6bxe/romstage.c
@@ -16,13 +16,10 @@
 
 #include <stdint.h>
 #include <device/pci_def.h>
-#include <arch/io.h>
 #include <device/pnp_def.h>
-#include <stdlib.h>
 #include <console/console.h>
 #include <southbridge/intel/i82371eb/i82371eb.h>
 #include <northbridge/intel/i440bx/raminit.h>
-#include <delay.h>
 #include <cpu/x86/bist.h>
 #include <cpu/intel/romstage.h>
 #include <superio/ite/it8671f/it8671f.h>
diff --git a/src/mainboard/msi/ms6119/romstage.c b/src/mainboard/msi/ms6119/romstage.c
index 48e62fc..7791e91 100644
--- a/src/mainboard/msi/ms6119/romstage.c
+++ b/src/mainboard/msi/ms6119/romstage.c
@@ -15,14 +15,11 @@
  */
 
 #include <stdint.h>
-#include <stdlib.h>
 #include <device/pci_def.h>
-#include <arch/io.h>
 #include <device/pnp_def.h>
 #include <console/console.h>
 #include <southbridge/intel/i82371eb/i82371eb.h>
 #include <northbridge/intel/i440bx/raminit.h>
-#include <delay.h>
 #include <cpu/x86/bist.h>
 #include <cpu/intel/romstage.h>
 #include <superio/winbond/common/winbond.h>
diff --git a/src/mainboard/msi/ms6147/romstage.c b/src/mainboard/msi/ms6147/romstage.c
index b6bb887..8cda4b8 100644
--- a/src/mainboard/msi/ms6147/romstage.c
+++ b/src/mainboard/msi/ms6147/romstage.c
@@ -15,14 +15,11 @@
  */
 
 #include <stdint.h>
-#include <stdlib.h>
 #include <device/pci_def.h>
-#include <arch/io.h>
 #include <device/pnp_def.h>
 #include <console/console.h>
 #include <southbridge/intel/i82371eb/i82371eb.h>
 #include <northbridge/intel/i440bx/raminit.h>
-#include <delay.h>
 #include <cpu/x86/bist.h>
 #include <cpu/intel/romstage.h>
 #include <superio/winbond/common/winbond.h>
diff --git a/src/mainboard/msi/ms6156/romstage.c b/src/mainboard/msi/ms6156/romstage.c
index a7c02cd..cf39f52 100644
--- a/src/mainboard/msi/ms6156/romstage.c
+++ b/src/mainboard/msi/ms6156/romstage.c
@@ -15,14 +15,11 @@
  */
 
 #include <stdint.h>
-#include <stdlib.h>
 #include <device/pci_def.h>
-#include <arch/io.h>
 #include <device/pnp_def.h>
 #include <console/console.h>
 #include <southbridge/intel/i82371eb/i82371eb.h>
 #include <northbridge/intel/i440bx/raminit.h>
-#include <delay.h>
 #include <cpu/x86/bist.h>
 #include <cpu/intel/romstage.h>
 #include <superio/winbond/common/winbond.h>
diff --git a/src/mainboard/nokia/ip530/romstage.c b/src/mainboard/nokia/ip530/romstage.c
index 7ab7124..e647aae 100644
--- a/src/mainboard/nokia/ip530/romstage.c
+++ b/src/mainboard/nokia/ip530/romstage.c
@@ -14,15 +14,11 @@
  * GNU General Public License for more details.
  */
 
-#include <stdint.h>
 #include <device/pci_def.h>
-#include <arch/io.h>
 #include <device/pnp_def.h>
-#include <stdlib.h>
 #include <console/console.h>
 #include <southbridge/intel/i82371eb/i82371eb.h>
 #include <northbridge/intel/i440bx/raminit.h>
-#include <delay.h>
 #include <cpu/x86/bist.h>
 #include <cpu/intel/romstage.h>
 #include <superio/smsc/smscsuperio/smscsuperio.h>
diff --git a/src/mainboard/soyo/sy-6ba-plus-iii/romstage.c b/src/mainboard/soyo/sy-6ba-plus-iii/romstage.c
index 360e550..770a7cb 100644
--- a/src/mainboard/soyo/sy-6ba-plus-iii/romstage.c
+++ b/src/mainboard/soyo/sy-6ba-plus-iii/romstage.c
@@ -16,13 +16,10 @@
 
 #include <stdint.h>
 #include <device/pci_def.h>
-#include <arch/io.h>
 #include <device/pnp_def.h>
-#include <stdlib.h>
 #include <console/console.h>
 #include <southbridge/intel/i82371eb/i82371eb.h>
 #include <northbridge/intel/i440bx/raminit.h>
-#include <delay.h>
 #include <cpu/x86/bist.h>
 #include <cpu/intel/romstage.h>
 #include <superio/ite/it8671f/it8671f.h>
diff --git a/src/mainboard/tyan/s1846/romstage.c b/src/mainboard/tyan/s1846/romstage.c
index 01940ae..4819b8a 100644
--- a/src/mainboard/tyan/s1846/romstage.c
+++ b/src/mainboard/tyan/s1846/romstage.c
@@ -14,15 +14,11 @@
  * GNU General Public License for more details.
  */
 
-#include <stdint.h>
 #include <device/pci_def.h>
-#include <arch/io.h>
 #include <device/pnp_def.h>
-#include <stdlib.h>
 #include <console/console.h>
 #include <southbridge/intel/i82371eb/i82371eb.h>
 #include <northbridge/intel/i440bx/raminit.h>
-#include <delay.h>
 #include <cpu/x86/bist.h>
 #include <cpu/intel/romstage.h>
 #include <superio/nsc/pc87309/pc87309.h>

-- 
To view, visit https://review.coreboot.org/20693
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I89ddeda3c90e1a4907c05851185b69f3b29e54ba
Gerrit-Change-Number: 20693
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Hui <buurin at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170723/ede4f5a3/attachment.html>

More information about the coreboot-gerrit mailing list