<p>Martin Roth <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/20693">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">440BX boards: Drop unused #includes from romstage<br><br>Romstage of many 440BX boards included headers that are not used.<br>Remove them as part of a bigger cleanup effort.<br><br>Change-Id: I89ddeda3c90e1a4907c05851185b69f3b29e54ba<br>Signed-off-by: Keith Hui <buurin@gmail.com><br>Reviewed-on: https://review.coreboot.org/20693<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Martin Roth <martinroth@google.com><br>---<br>M src/mainboard/a-trend/atc-6220/romstage.c<br>M src/mainboard/a-trend/atc-6240/romstage.c<br>M src/mainboard/asus/p2b-ds/romstage.c<br>M src/mainboard/asus/p2b-ls/romstage.c<br>M src/mainboard/asus/p2b/romstage.c<br>M src/mainboard/asus/p3b-f/romstage.c<br>M src/mainboard/azza/pt-6ibd/romstage.c<br>M src/mainboard/gigabyte/ga-6bxc/romstage.c<br>M src/mainboard/gigabyte/ga-6bxe/romstage.c<br>M src/mainboard/msi/ms6119/romstage.c<br>M src/mainboard/msi/ms6147/romstage.c<br>M src/mainboard/msi/ms6156/romstage.c<br>M src/mainboard/nokia/ip530/romstage.c<br>M src/mainboard/soyo/sy-6ba-plus-iii/romstage.c<br>M src/mainboard/tyan/s1846/romstage.c<br>15 files changed, 0 insertions(+), 55 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/a-trend/atc-6220/romstage.c b/src/mainboard/a-trend/atc-6220/romstage.c<br>index 09e0183..6cf86c1 100644<br>--- a/src/mainboard/a-trend/atc-6220/romstage.c<br>+++ b/src/mainboard/a-trend/atc-6220/romstage.c<br>@@ -14,20 +14,15 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br> #include <device/pci_def.h><br>-#include <arch/io.h><br> #include <device/pnp_def.h><br>-#include <stdlib.h><br> #include <console/console.h><br> #include <southbridge/intel/i82371eb/i82371eb.h><br> #include <northbridge/intel/i440bx/raminit.h><br>-#include <delay.h><br> #include <cpu/x86/bist.h><br> #include <cpu/intel/romstage.h><br> #include <superio/winbond/common/winbond.h><br> #include <superio/winbond/w83977tf/w83977tf.h><br>-<br> #include <lib.h><br> <br> #define SERIAL_DEV PNP_DEV(0x3f0, W83977TF_SP1)<br>diff --git a/src/mainboard/a-trend/atc-6240/romstage.c b/src/mainboard/a-trend/atc-6240/romstage.c<br>index 11ce41b..cbb0207 100644<br>--- a/src/mainboard/a-trend/atc-6240/romstage.c<br>+++ b/src/mainboard/a-trend/atc-6240/romstage.c<br>@@ -14,15 +14,11 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br>-#include <stdlib.h><br> #include <device/pci_def.h><br>-#include <arch/io.h><br> #include <device/pnp_def.h><br> #include <console/console.h><br> #include <southbridge/intel/i82371eb/i82371eb.h><br> #include <northbridge/intel/i440bx/raminit.h><br>-#include <delay.h><br> #include <cpu/x86/bist.h><br> #include <cpu/intel/romstage.h><br> #include <superio/winbond/common/winbond.h><br>diff --git a/src/mainboard/asus/p2b-ds/romstage.c b/src/mainboard/asus/p2b-ds/romstage.c<br>index 694f03e..809f1f6 100644<br>--- a/src/mainboard/asus/p2b-ds/romstage.c<br>+++ b/src/mainboard/asus/p2b-ds/romstage.c<br>@@ -14,15 +14,11 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br> #include <device/pci_def.h><br>-#include <arch/io.h><br> #include <device/pnp_def.h><br>-#include <stdlib.h><br> #include <console/console.h><br> #include <southbridge/intel/i82371eb/i82371eb.h><br> #include <northbridge/intel/i440bx/raminit.h><br>-#include <delay.h><br> #include <cpu/x86/bist.h><br> #include <cpu/intel/romstage.h><br> #include <superio/winbond/common/winbond.h><br>diff --git a/src/mainboard/asus/p2b-ls/romstage.c b/src/mainboard/asus/p2b-ls/romstage.c<br>index acd15f7..5ed878f 100644<br>--- a/src/mainboard/asus/p2b-ls/romstage.c<br>+++ b/src/mainboard/asus/p2b-ls/romstage.c<br>@@ -14,15 +14,11 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br> #include <device/pci_def.h><br>-#include <arch/io.h><br> #include <device/pnp_def.h><br>-#include <stdlib.h><br> #include <console/console.h><br> #include <southbridge/intel/i82371eb/i82371eb.h><br> #include <northbridge/intel/i440bx/raminit.h><br>-#include <delay.h><br> #include <cpu/x86/bist.h><br> #include <cpu/intel/romstage.h><br> #include <superio/winbond/common/winbond.h><br>diff --git a/src/mainboard/asus/p2b/romstage.c b/src/mainboard/asus/p2b/romstage.c<br>index 09e0183..6cf86c1 100644<br>--- a/src/mainboard/asus/p2b/romstage.c<br>+++ b/src/mainboard/asus/p2b/romstage.c<br>@@ -14,20 +14,15 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br> #include <device/pci_def.h><br>-#include <arch/io.h><br> #include <device/pnp_def.h><br>-#include <stdlib.h><br> #include <console/console.h><br> #include <southbridge/intel/i82371eb/i82371eb.h><br> #include <northbridge/intel/i440bx/raminit.h><br>-#include <delay.h><br> #include <cpu/x86/bist.h><br> #include <cpu/intel/romstage.h><br> #include <superio/winbond/common/winbond.h><br> #include <superio/winbond/w83977tf/w83977tf.h><br>-<br> #include <lib.h><br> <br> #define SERIAL_DEV PNP_DEV(0x3f0, W83977TF_SP1)<br>diff --git a/src/mainboard/asus/p3b-f/romstage.c b/src/mainboard/asus/p3b-f/romstage.c<br>index 9d56d5b..bb16c78 100644<br>--- a/src/mainboard/asus/p3b-f/romstage.c<br>+++ b/src/mainboard/asus/p3b-f/romstage.c<br>@@ -14,15 +14,11 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br> #include <device/pci_def.h><br>-#include <arch/io.h><br> #include <device/pnp_def.h><br>-#include <stdlib.h><br> #include <console/console.h><br> #include <southbridge/intel/i82371eb/i82371eb.h><br> #include <northbridge/intel/i440bx/raminit.h><br>-#include <delay.h><br> #include <cpu/x86/bist.h><br> #include <cpu/intel/romstage.h><br> #include <superio/winbond/common/winbond.h><br>diff --git a/src/mainboard/azza/pt-6ibd/romstage.c b/src/mainboard/azza/pt-6ibd/romstage.c<br>index a9960db..c4cfbec 100644<br>--- a/src/mainboard/azza/pt-6ibd/romstage.c<br>+++ b/src/mainboard/azza/pt-6ibd/romstage.c<br>@@ -16,13 +16,10 @@<br> <br> #include <stdint.h><br> #include <device/pci_def.h><br>-#include <arch/io.h><br> #include <device/pnp_def.h><br>-#include <stdlib.h><br> #include <console/console.h><br> #include <southbridge/intel/i82371eb/i82371eb.h><br> #include <northbridge/intel/i440bx/raminit.h><br>-#include <delay.h><br> #include <cpu/x86/bist.h><br> #include <cpu/intel/romstage.h><br> #include <superio/winbond/common/winbond.h><br>diff --git a/src/mainboard/gigabyte/ga-6bxc/romstage.c b/src/mainboard/gigabyte/ga-6bxc/romstage.c<br>index 25e00c4..425a615 100644<br>--- a/src/mainboard/gigabyte/ga-6bxc/romstage.c<br>+++ b/src/mainboard/gigabyte/ga-6bxc/romstage.c<br>@@ -16,13 +16,10 @@<br> <br> #include <stdint.h><br> #include <device/pci_def.h><br>-#include <arch/io.h><br> #include <device/pnp_def.h><br>-#include <stdlib.h><br> #include <console/console.h><br> #include <southbridge/intel/i82371eb/i82371eb.h><br> #include <northbridge/intel/i440bx/raminit.h><br>-#include <delay.h><br> #include <cpu/x86/bist.h><br> #include <cpu/intel/romstage.h><br> #include <superio/ite/it8671f/it8671f.h><br>diff --git a/src/mainboard/gigabyte/ga-6bxe/romstage.c b/src/mainboard/gigabyte/ga-6bxe/romstage.c<br>index e49e50c..85b36b9 100644<br>--- a/src/mainboard/gigabyte/ga-6bxe/romstage.c<br>+++ b/src/mainboard/gigabyte/ga-6bxe/romstage.c<br>@@ -16,13 +16,10 @@<br> <br> #include <stdint.h><br> #include <device/pci_def.h><br>-#include <arch/io.h><br> #include <device/pnp_def.h><br>-#include <stdlib.h><br> #include <console/console.h><br> #include <southbridge/intel/i82371eb/i82371eb.h><br> #include <northbridge/intel/i440bx/raminit.h><br>-#include <delay.h><br> #include <cpu/x86/bist.h><br> #include <cpu/intel/romstage.h><br> #include <superio/ite/it8671f/it8671f.h><br>diff --git a/src/mainboard/msi/ms6119/romstage.c b/src/mainboard/msi/ms6119/romstage.c<br>index 48e62fc..7791e91 100644<br>--- a/src/mainboard/msi/ms6119/romstage.c<br>+++ b/src/mainboard/msi/ms6119/romstage.c<br>@@ -15,14 +15,11 @@<br>  */<br> <br> #include <stdint.h><br>-#include <stdlib.h><br> #include <device/pci_def.h><br>-#include <arch/io.h><br> #include <device/pnp_def.h><br> #include <console/console.h><br> #include <southbridge/intel/i82371eb/i82371eb.h><br> #include <northbridge/intel/i440bx/raminit.h><br>-#include <delay.h><br> #include <cpu/x86/bist.h><br> #include <cpu/intel/romstage.h><br> #include <superio/winbond/common/winbond.h><br>diff --git a/src/mainboard/msi/ms6147/romstage.c b/src/mainboard/msi/ms6147/romstage.c<br>index b6bb887..8cda4b8 100644<br>--- a/src/mainboard/msi/ms6147/romstage.c<br>+++ b/src/mainboard/msi/ms6147/romstage.c<br>@@ -15,14 +15,11 @@<br>  */<br> <br> #include <stdint.h><br>-#include <stdlib.h><br> #include <device/pci_def.h><br>-#include <arch/io.h><br> #include <device/pnp_def.h><br> #include <console/console.h><br> #include <southbridge/intel/i82371eb/i82371eb.h><br> #include <northbridge/intel/i440bx/raminit.h><br>-#include <delay.h><br> #include <cpu/x86/bist.h><br> #include <cpu/intel/romstage.h><br> #include <superio/winbond/common/winbond.h><br>diff --git a/src/mainboard/msi/ms6156/romstage.c b/src/mainboard/msi/ms6156/romstage.c<br>index a7c02cd..cf39f52 100644<br>--- a/src/mainboard/msi/ms6156/romstage.c<br>+++ b/src/mainboard/msi/ms6156/romstage.c<br>@@ -15,14 +15,11 @@<br>  */<br> <br> #include <stdint.h><br>-#include <stdlib.h><br> #include <device/pci_def.h><br>-#include <arch/io.h><br> #include <device/pnp_def.h><br> #include <console/console.h><br> #include <southbridge/intel/i82371eb/i82371eb.h><br> #include <northbridge/intel/i440bx/raminit.h><br>-#include <delay.h><br> #include <cpu/x86/bist.h><br> #include <cpu/intel/romstage.h><br> #include <superio/winbond/common/winbond.h><br>diff --git a/src/mainboard/nokia/ip530/romstage.c b/src/mainboard/nokia/ip530/romstage.c<br>index 7ab7124..e647aae 100644<br>--- a/src/mainboard/nokia/ip530/romstage.c<br>+++ b/src/mainboard/nokia/ip530/romstage.c<br>@@ -14,15 +14,11 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br> #include <device/pci_def.h><br>-#include <arch/io.h><br> #include <device/pnp_def.h><br>-#include <stdlib.h><br> #include <console/console.h><br> #include <southbridge/intel/i82371eb/i82371eb.h><br> #include <northbridge/intel/i440bx/raminit.h><br>-#include <delay.h><br> #include <cpu/x86/bist.h><br> #include <cpu/intel/romstage.h><br> #include <superio/smsc/smscsuperio/smscsuperio.h><br>diff --git a/src/mainboard/soyo/sy-6ba-plus-iii/romstage.c b/src/mainboard/soyo/sy-6ba-plus-iii/romstage.c<br>index 360e550..770a7cb 100644<br>--- a/src/mainboard/soyo/sy-6ba-plus-iii/romstage.c<br>+++ b/src/mainboard/soyo/sy-6ba-plus-iii/romstage.c<br>@@ -16,13 +16,10 @@<br> <br> #include <stdint.h><br> #include <device/pci_def.h><br>-#include <arch/io.h><br> #include <device/pnp_def.h><br>-#include <stdlib.h><br> #include <console/console.h><br> #include <southbridge/intel/i82371eb/i82371eb.h><br> #include <northbridge/intel/i440bx/raminit.h><br>-#include <delay.h><br> #include <cpu/x86/bist.h><br> #include <cpu/intel/romstage.h><br> #include <superio/ite/it8671f/it8671f.h><br>diff --git a/src/mainboard/tyan/s1846/romstage.c b/src/mainboard/tyan/s1846/romstage.c<br>index 01940ae..4819b8a 100644<br>--- a/src/mainboard/tyan/s1846/romstage.c<br>+++ b/src/mainboard/tyan/s1846/romstage.c<br>@@ -14,15 +14,11 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br> #include <device/pci_def.h><br>-#include <arch/io.h><br> #include <device/pnp_def.h><br>-#include <stdlib.h><br> #include <console/console.h><br> #include <southbridge/intel/i82371eb/i82371eb.h><br> #include <northbridge/intel/i440bx/raminit.h><br>-#include <delay.h><br> #include <cpu/x86/bist.h><br> #include <cpu/intel/romstage.h><br> #include <superio/nsc/pc87309/pc87309.h><br></pre><p>To view, visit <a href="https://review.coreboot.org/20693">change 20693</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20693"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I89ddeda3c90e1a4907c05851185b69f3b29e54ba </div>
<div style="display:none"> Gerrit-Change-Number: 20693 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Keith Hui <buurin@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>