[coreboot-gerrit] Change in coreboot[master]: amp/pi/hudson: Initialize the UART to avoid partial hung

[Ricardo Ribalda Delgado (Code Review)]

Ricardo Ribalda Delgado has uploaded this change for review. ( https://review.coreboot.org/20679


Change subject: amp/pi/hudson: Initialize the UART to avoid partial hung
......................................................................

amp/pi/hudson: Initialize the UART to avoid partial hung

When USE_OPTION_TABLE is enabled, the readout of baudrate and loglevel
from the CMOS results on printks:

CBFS: 'Master Header Locator' located CBFS at [100:ffffc0)
CBFS: Locating 'cmos_layout.bin'
CBFS: Found @ offset 150c0 size 6d0
CBFS: 'Master Header Locator' located CBFS at [100:ffffc0)
CBFS: Locating 'cmos_layout.bin'
CBFS: Found @ offset 150c0 size 6d0

before the uart is initialized. Resulting in a long delay before
the "coreboot romstage starting..." is printed

This patch solves this issue by doing a basic configuration of the UART.

Change-Id: I42f02f1a60784b0409bf7866933bb180b704cd56
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda at gmail.com>
---
M src/southbridge/amd/pi/hudson/early_setup.c
1 file changed, 16 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/20679/1

diff --git a/src/southbridge/amd/pi/hudson/early_setup.c b/src/southbridge/amd/pi/hudson/early_setup.c
index b5e753d..61d57c9 100644
--- a/src/southbridge/amd/pi/hudson/early_setup.c
+++ b/src/southbridge/amd/pi/hudson/early_setup.c
@@ -50,6 +50,22 @@
 
 	udelay(2000);
 	write8((void *)0xFEDC6000 + 0x2000 * CONFIG_UART_FOR_CONSOLE + 0x88, 0x01); /* reset UART */
+
+	/*Initial UART configuration*/
+	write8((void *)0xFEDC6000 + 0x2000 * CONFIG_UART_FOR_CONSOLE + 1 * 4,
+	       0x00);
+	write8((void *)0xFEDC6000 + 0x2000 * CONFIG_UART_FOR_CONSOLE + 2 * 4,
+	       0x01);
+	write8((void *)0xFEDC6000 + 0x2000 * CONFIG_UART_FOR_CONSOLE + 4 * 4,
+	       0x03);
+	write8((void *)0xFEDC6000 + 0x2000 * CONFIG_UART_FOR_CONSOLE + 3 * 4,
+	       0x83);
+	write8((void *)0xFEDC6000 + 0x2000 * CONFIG_UART_FOR_CONSOLE + 0 * 4,
+	       0x1a);
+	write8((void *)0xFEDC6000 + 0x2000 * CONFIG_UART_FOR_CONSOLE + 1 * 4,
+	       0x00);
+	write8((void *)0xFEDC6000 + 0x2000 * CONFIG_UART_FOR_CONSOLE + 3 * 4,
+	       0x03);
 }
 
 #endif

-- 
To view, visit https://review.coreboot.org/20679
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I42f02f1a60784b0409bf7866933bb180b704cd56
Gerrit-Change-Number: 20679
Gerrit-PatchSet: 1
Gerrit-Owner: Ricardo Ribalda Delgado <ricardo.ribalda at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170721/500153dd/attachment.html>