<p>Ricardo Ribalda Delgado has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20679">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">amp/pi/hudson: Initialize the UART to avoid partial hung<br><br>When USE_OPTION_TABLE is enabled, the readout of baudrate and loglevel<br>from the CMOS results on printks:<br><br>CBFS: 'Master Header Locator' located CBFS at [100:ffffc0)<br>CBFS: Locating 'cmos_layout.bin'<br>CBFS: Found @ offset 150c0 size 6d0<br>CBFS: 'Master Header Locator' located CBFS at [100:ffffc0)<br>CBFS: Locating 'cmos_layout.bin'<br>CBFS: Found @ offset 150c0 size 6d0<br><br>before the uart is initialized. Resulting in a long delay before<br>the "coreboot romstage starting..." is printed<br><br>This patch solves this issue by doing a basic configuration of the UART.<br><br>Change-Id: I42f02f1a60784b0409bf7866933bb180b704cd56<br>Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com><br>---<br>M src/southbridge/amd/pi/hudson/early_setup.c<br>1 file changed, 16 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/20679/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/southbridge/amd/pi/hudson/early_setup.c b/src/southbridge/amd/pi/hudson/early_setup.c<br>index b5e753d..61d57c9 100644<br>--- a/src/southbridge/amd/pi/hudson/early_setup.c<br>+++ b/src/southbridge/amd/pi/hudson/early_setup.c<br>@@ -50,6 +50,22 @@<br> <br>      udelay(2000);<br>         write8((void *)0xFEDC6000 + 0x2000 * CONFIG_UART_FOR_CONSOLE + 0x88, 0x01); /* reset UART */<br>+<br>+      /*Initial UART configuration*/<br>+       write8((void *)0xFEDC6000 + 0x2000 * CONFIG_UART_FOR_CONSOLE + 1 * 4,<br>+               0x00);<br>+        write8((void *)0xFEDC6000 + 0x2000 * CONFIG_UART_FOR_CONSOLE + 2 * 4,<br>+               0x01);<br>+        write8((void *)0xFEDC6000 + 0x2000 * CONFIG_UART_FOR_CONSOLE + 4 * 4,<br>+               0x03);<br>+        write8((void *)0xFEDC6000 + 0x2000 * CONFIG_UART_FOR_CONSOLE + 3 * 4,<br>+               0x83);<br>+        write8((void *)0xFEDC6000 + 0x2000 * CONFIG_UART_FOR_CONSOLE + 0 * 4,<br>+               0x1a);<br>+        write8((void *)0xFEDC6000 + 0x2000 * CONFIG_UART_FOR_CONSOLE + 1 * 4,<br>+               0x00);<br>+        write8((void *)0xFEDC6000 + 0x2000 * CONFIG_UART_FOR_CONSOLE + 3 * 4,<br>+               0x03);<br> }<br> <br> #endif<br></pre><p>To view, visit <a href="https://review.coreboot.org/20679">change 20679</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20679"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I42f02f1a60784b0409bf7866933bb180b704cd56 </div>
<div style="display:none"> Gerrit-Change-Number: 20679 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> </div>