[coreboot-gerrit] Change in coreboot[master]: amd/XX/hudson: Remove #if IS_ENABLED(CONFIG_HUDSON_IMC_FWM)

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/20677 )

Change subject: amd/XX/hudson: Remove #if IS_ENABLED(CONFIG_HUDSON_IMC_FWM)
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/20677/1/src/mainboard/amd/bettong/BiosCallOuts.c
File src/mainboard/amd/bettong/BiosCallOuts.c:

https://review.coreboot.org/#/c/20677/1/src/mainboard/amd/bettong/BiosCallOuts.c@26
PS1, Line 26: "imc.h"
This should really be #include <imc.h> - but most of the above ones are wrong too.  Future patches, I guess.


https://review.coreboot.org/#/c/20677/1/src/mainboard/amd/db-ft3b-lc/BiosCallOuts.c
File src/mainboard/amd/db-ft3b-lc/BiosCallOuts.c:

https://review.coreboot.org/#/c/20677/1/src/mainboard/amd/db-ft3b-lc/BiosCallOuts.c@143
PS1, Line 143: FALSE to call FchECfancontrolservice */
The > 80 column lines should be wrapped.  Maybe in a future patch...


https://review.coreboot.org/#/c/20677/1/src/soc/amd/stoneyridge/include/fchec.h
File src/soc/amd/stoneyridge/include/fchec.h:

https://review.coreboot.org/#/c/20677/1/src/soc/amd/stoneyridge/include/fchec.h@16
PS1, Line 16: AMD_GARDENIA_FCHEC
I'll have to update this.


https://review.coreboot.org/#/c/20677/1/src/southbridge/amd/pi/hudson/fchec.h
File src/southbridge/amd/pi/hudson/fchec.h:

https://review.coreboot.org/#/c/20677/1/src/southbridge/amd/pi/hudson/fchec.h@16
PS1, Line 16: AMD_BETTONG_FCHEC
Need to update this.



-- 
To view, visit https://review.coreboot.org/20677
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd271c6ab618aa4badf81c702212e7de35317021
Gerrit-Change-Number: 20677
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Comment-Date: Fri, 21 Jul 2017 03:00:36 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170721/60329116/attachment.html>