<p>Martin Roth <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/20677">View Change</a></p><p>Patch set 1:</p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/20677/1/src/mainboard/amd/bettong/BiosCallOuts.c">File src/mainboard/amd/bettong/BiosCallOuts.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20677/1/src/mainboard/amd/bettong/BiosCallOuts.c@26">Patch Set #1, Line 26:</a> <code style="font-family:monospace,monospace">"imc.h"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should really be #include <imc.h> - but most of the above ones are wrong too.  Future patches, I guess.</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/20677/1/src/mainboard/amd/db-ft3b-lc/BiosCallOuts.c">File src/mainboard/amd/db-ft3b-lc/BiosCallOuts.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20677/1/src/mainboard/amd/db-ft3b-lc/BiosCallOuts.c@143">Patch Set #1, Line 143:</a> <code style="font-family:monospace,monospace">FALSE to call FchECfancontrolservice */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">The > 80 column lines should be wrapped.  Maybe in a future patch...</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/20677/1/src/soc/amd/stoneyridge/include/fchec.h">File src/soc/amd/stoneyridge/include/fchec.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20677/1/src/soc/amd/stoneyridge/include/fchec.h@16">Patch Set #1, Line 16:</a> <code style="font-family:monospace,monospace">AMD_GARDENIA_FCHEC</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'll have to update this.</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/20677/1/src/southbridge/amd/pi/hudson/fchec.h">File src/southbridge/amd/pi/hudson/fchec.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20677/1/src/southbridge/amd/pi/hudson/fchec.h@16">Patch Set #1, Line 16:</a> <code style="font-family:monospace,monospace">AMD_BETTONG_FCHEC</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Need to update this.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/20677">change 20677</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20677"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Idd271c6ab618aa4badf81c702212e7de35317021 </div>
<div style="display:none"> Gerrit-Change-Number: 20677 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 21 Jul 2017 03:00:36 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>