[coreboot-gerrit] Change in coreboot[master]: northbridge/intel/i440bx: Merge RAM init routines
Keith Hui (Code Review)
gerrit at coreboot.org
Fri Jul 21 03:21:21 CEST 2017
Keith Hui has uploaded this change for review. ( https://review.coreboot.org/20676
Change subject: northbridge/intel/i440bx: Merge RAM init routines
......................................................................
northbridge/intel/i440bx: Merge RAM init routines
There are 4 routines used in RAM init that most if not all
i440bx mainboards call in the same order. Implements a single
RAM init routine for them to allow for future consolidation.
Boards to be changed to use this one routine in a future change.
Change-Id: Ib553b07b117de12b7982586bce0f9355f55013a0
Signed-off-by: Keith Hui <buurin at gmail.com>
---
M src/northbridge/intel/i440bx/raminit.c
M src/northbridge/intel/i440bx/raminit.h
2 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/20676/1
diff --git a/src/northbridge/intel/i440bx/raminit.c b/src/northbridge/intel/i440bx/raminit.c
index 67d8d3f..89e57e6 100644
--- a/src/northbridge/intel/i440bx/raminit.c
+++ b/src/northbridge/intel/i440bx/raminit.c
@@ -979,3 +979,12 @@
PRINT_DEBUG("Northbridge following SDRAM init:\n");
DUMPNORTH();
}
+
+void sdram_initialize(void)
+{
+ dump_spd_registers();
+ sdram_set_registers();
+ sdram_set_spd_registers();
+ sdram_enable();
+}
+
diff --git a/src/northbridge/intel/i440bx/raminit.h b/src/northbridge/intel/i440bx/raminit.h
index 609b591..e20d559 100644
--- a/src/northbridge/intel/i440bx/raminit.h
+++ b/src/northbridge/intel/i440bx/raminit.h
@@ -25,6 +25,9 @@
void sdram_set_registers(void);
void sdram_set_spd_registers(void);
void sdram_enable(void);
+/* A merger of above functions */
+void sdram_initialize(void);
+
/* Debug */
#if IS_ENABLED(CONFIG_DEBUG_RAM_SETUP)
void dump_spd_registers(void);
--
To view, visit https://review.coreboot.org/20676
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib553b07b117de12b7982586bce0f9355f55013a0
Gerrit-Change-Number: 20676
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Hui <buurin at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170721/85f3676d/attachment-0001.html>
More information about the coreboot-gerrit
mailing list