<p>Keith Hui has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20676">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">northbridge/intel/i440bx: Merge RAM init routines<br><br>There are 4 routines used in RAM init that most if not all<br>i440bx mainboards call in the same order. Implements a single<br>RAM init routine for them to allow for future consolidation.<br>Boards to be changed to use this one routine in a future change.<br><br>Change-Id: Ib553b07b117de12b7982586bce0f9355f55013a0<br>Signed-off-by: Keith Hui <buurin@gmail.com><br>---<br>M src/northbridge/intel/i440bx/raminit.c<br>M src/northbridge/intel/i440bx/raminit.h<br>2 files changed, 12 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/20676/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/northbridge/intel/i440bx/raminit.c b/src/northbridge/intel/i440bx/raminit.c<br>index 67d8d3f..89e57e6 100644<br>--- a/src/northbridge/intel/i440bx/raminit.c<br>+++ b/src/northbridge/intel/i440bx/raminit.c<br>@@ -979,3 +979,12 @@<br>   PRINT_DEBUG("Northbridge following SDRAM init:\n");<br>         DUMPNORTH();<br> }<br>+<br>+void sdram_initialize(void)<br>+{<br>+        dump_spd_registers();<br>+        sdram_set_registers();<br>+       sdram_set_spd_registers();<br>+   sdram_enable();<br>+}<br>+<br>diff --git a/src/northbridge/intel/i440bx/raminit.h b/src/northbridge/intel/i440bx/raminit.h<br>index 609b591..e20d559 100644<br>--- a/src/northbridge/intel/i440bx/raminit.h<br>+++ b/src/northbridge/intel/i440bx/raminit.h<br>@@ -25,6 +25,9 @@<br> void sdram_set_registers(void);<br> void sdram_set_spd_registers(void);<br> void sdram_enable(void);<br>+/* A merger of above functions */<br>+void sdram_initialize(void);<br>+<br> /* Debug */<br> #if IS_ENABLED(CONFIG_DEBUG_RAM_SETUP)<br> void dump_spd_registers(void);<br></pre><p>To view, visit <a href="https://review.coreboot.org/20676">change 20676</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20676"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib553b07b117de12b7982586bce0f9355f55013a0 </div>
<div style="display:none"> Gerrit-Change-Number: 20676 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Keith Hui <buurin@gmail.com> </div>