[coreboot-gerrit] Change in coreboot[master]: northbridge/intel/i440bx: Move NB macro to i440bx.h

Keith Hui (Code Review) gerrit at coreboot.org
Fri Jul 21 03:05:52 CEST 2017


Keith Hui has uploaded this change for review. ( https://review.coreboot.org/20675


Change subject: northbridge/intel/i440bx: Move NB macro to i440bx.h
......................................................................

northbridge/intel/i440bx: Move NB macro to i440bx.h

This move makes the NB macro more widely available,
in preparation for implementing get_top_of_ram().

Change-Id: Icd8e82cfdfdccb662b2139d0e5d1d5af72cbae7f
Signed-off-by: Keith Hui <buurin at gmail.com>
---
M src/northbridge/intel/i440bx/i440bx.h
M src/northbridge/intel/i440bx/raminit.c
2 files changed, 6 insertions(+), 6 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/20675/1

diff --git a/src/northbridge/intel/i440bx/i440bx.h b/src/northbridge/intel/i440bx/i440bx.h
index 4724719..6e93e83 100644
--- a/src/northbridge/intel/i440bx/i440bx.h
+++ b/src/northbridge/intel/i440bx/i440bx.h
@@ -86,4 +86,6 @@
 #define DRTC    0xe8 /* DRAM Read Thermal Throttling Control (0x000..000). */
 #define BUFFC   0xf0 /* Buffer Control Register (0x0000). */
 
+#define NB PCI_DEV(0, 0, 0)
+
 #endif /* NORTHBRIDGE_INTEL_I440BX_I440BX_H */
diff --git a/src/northbridge/intel/i440bx/raminit.c b/src/northbridge/intel/i440bx/raminit.c
index 86e9595..67d8d3f 100644
--- a/src/northbridge/intel/i440bx/raminit.c
+++ b/src/northbridge/intel/i440bx/raminit.c
@@ -2,7 +2,7 @@
  * This file is part of the coreboot project.
  *
  * Copyright (C) 2007-2008 Uwe Hermann <uwe at hermann-uwe.de>
- * Copyright (C) 2010 Keith Hui <buurin at gmail.com>
+ * Copyright (C) 2010,2017 Keith Hui <buurin at gmail.com>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -25,11 +25,9 @@
 #include "i440bx.h"
 #include "raminit.h"
 
-/*-----------------------------------------------------------------------------
-Macros and definitions.
------------------------------------------------------------------------------*/
-
-#define NB PCI_DEV(0, 0, 0)
+/*
+ * Macros and definitions
+ */
 
 /* Debugging macros. */
 #if IS_ENABLED(CONFIG_DEBUG_RAM_SETUP)

-- 
To view, visit https://review.coreboot.org/20675
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd8e82cfdfdccb662b2139d0e5d1d5af72cbae7f
Gerrit-Change-Number: 20675
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Hui <buurin at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170721/8960f7c8/attachment.html>


More information about the coreboot-gerrit mailing list