[coreboot-gerrit] Change in coreboot[master]: [WIP]: mainboard/google/soraka: wacom touchscreen support

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/20476 )

Change subject: [WIP]: mainboard/google/soraka: wacom touchscreen support
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants/baseboard/gpio.c
File src/mainboard/google/poppy/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants/baseboard/gpio.c@237
PS1, Line 237: 1
Why take the device out of reset here? It should be taken care of by the ACPI power resource.


https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants/soraka/devicetree.cb
File src/mainboard/google/poppy/variants/soraka/devicetree.cb:

https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants/soraka/devicetree.cb@a217
PS1, Line 217: 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
I don't think we should get rid of this node right away. Older proto boards would still be using this.


https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants/soraka/devicetree.cb@218
PS1, Line 218: WCOMNTN2
Is this supposed to be WCOM50C1?


https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants/soraka/devicetree.cb@223
PS1, Line 223: "
As per datasheet, this should be at least 100ms.



-- 
To view, visit https://review.coreboot.org/20476
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fbae4782c6442149cda57d23c61ed87546621bb
Gerrit-Change-Number: 20476
Gerrit-PatchSet: 1
Gerrit-Owner: Wisley Chen <wisley.chen at quantatw.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 07 Jul 2017 05:35:51 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170707/1a95fe47/attachment.html>