<p>Furquan Shaikh <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/20476">View Change</a></p><p>Patch set 1:</p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants/baseboard/gpio.c">File src/mainboard/google/poppy/variants/baseboard/gpio.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants/baseboard/gpio.c@237">Patch Set #1, Line 237:</a> <code style="font-family:monospace,monospace">1</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why take the device out of reset here? It should be taken care of by the ACPI power resource.</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants/soraka/devicetree.cb">File src/mainboard/google/poppy/variants/soraka/devicetree.cb:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants/soraka/devicetree.cb@a217">Patch Set #1, Line 217:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><br><br><br><br><br><br><br><br><br><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't think we should get rid of this node right away. Older proto boards would still be using this.</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants/soraka/devicetree.cb@218">Patch Set #1, Line 218:</a> <code style="font-family:monospace,monospace">WCOMNTN2</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is this supposed to be WCOM50C1?</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants/soraka/devicetree.cb@223">Patch Set #1, Line 223:</a> <code style="font-family:monospace,monospace">"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">As per datasheet, this should be at least 100ms.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/20476">change 20476</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20476"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I0fbae4782c6442149cda57d23c61ed87546621bb </div>
<div style="display:none"> Gerrit-Change-Number: 20476 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Wisley Chen <wisley.chen@quantatw.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Naresh Solanki <naresh.solanki@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 07 Jul 2017 05:35:51 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>