[coreboot-gerrit] Patch set updated for coreboot: SeaBIOS Kconfig: Update logging

[Martin Roth (martinroth@google.com)]

Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18210

-gerrit

commit 6c3cbda90f0253daa04022ea0c830ce7301258c8
Author: Martin Roth <martinroth at google.com>
Date:   Mon Jan 23 14:56:55 2017 -0700

    SeaBIOS Kconfig: Update logging
    
    The SeaBIOS and coreboot log levels don't really align, so setting the
    SeaBIOS log level to the same as coreboot's isn't really what we want.
    Below log level 5, coreboot logs very little, so set the SeaBIOS log
    level to 0, then increase the default log slowly level from there.
    
    - Update default log levels.
    - Update the current help text to match the new defaults.
    - Add help text for what is displayed at various levels.
    - Get rid of separate type & prompt lines.
    
    Change-Id: I5a8b75bd44748cb94a83a77ac3a379c8a9587e7b
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 payloads/external/SeaBIOS/Kconfig | 33 ++++++++++++++++++++++++++-------
 1 file changed, 26 insertions(+), 7 deletions(-)

diff --git a/payloads/external/SeaBIOS/Kconfig b/payloads/external/SeaBIOS/Kconfig
index 276f75d..ad3f5c3 100644
--- a/payloads/external/SeaBIOS/Kconfig
+++ b/payloads/external/SeaBIOS/Kconfig
@@ -95,13 +95,32 @@ config PAYLOAD_VGABIOS_FILE
 	default "payloads/external/SeaBIOS/seabios/out/vgabios.bin"
 
 config SEABIOS_DEBUG_LEVEL
-	prompt "SeaBIOS debug level (verbosity)"
-	default DEFAULT_CONSOLE_LOGLEVEL
-	int
+	int "SeaBIOS debug level (verbosity)"
+	default 2 if DEFAULT_CONSOLE_LOGLEVEL_8 || DEFAULT_CONSOLE_LOGLEVEL_7
+	default 1 if DEFAULT_CONSOLE_LOGLEVEL_6 || DEFAULT_CONSOLE_LOGLEVEL_5
+	default 0
 	help
-	  The higher the number, the more verbose SeaBIOS will be. The range is
-	  not well defined but the typical values range from 0 to about 9 inclusive
-	  where 0 disables all output. Set this value to -1 to use SeaBIOS' default.
+	  The higher the number, the more verbose SeaBIOS will be. See the table
+	  below for the current values corresponding to various items as of SeaBIOS
+	  version 1.10.1. Set this value to -1 to use SeaBIOS' default.
+
+	  Defaults to no output for coreboot log levels 4 (Warning) and below
+	  Defaults to Basic output (1) for coreboot log levels 5 (Notice) & 6 (Info)
+	  Defaults to SeaBIOS log level 2 for coreboot levels 7 (Debug) & 8 (Spew)
+
+	  Output at various SeaBIOS log levels:
+	  level 0  - Logging disabled
+	  level 1  - Basic output, interrupts 5, 18h, 19h, 40h, SMP, PNP, PMM
+	  level 2  - AHCI, Floppy, Basic ps2, interrupts 11h, 12h, 14h, 17h
+	  level 3  - bootsplash, initializations, SeaBIOS VGA BIOS interrupts
+	  level 4  - bios tables, more optionrom
+	  level 5  - Extra bootsplash, more XHCI
+	  level 6  - ATA commands, extra optionrom
+	  level 7  - extra ps2 commands, more OHCI & EHCI
+	  level 8  - extra malloc info, more AHCI
+	  level 9  - interrupts 15h, 16h, 1ah, APM, PCI, SMIs, PCIBIOS,
+	             USB-HID commands, SDcard commands, Floppy commands
+	  level 10 - interrupt 13h (Drives other than floppy)
+	  level 20 - interrupt 10h (Display)
 
-	  The default is to use coreboot's loglevel.
 endif