[coreboot-gerrit] New patch to review for coreboot: google/snappy: Use exported GPIOs and ACPI regulator for touchscreen

Wisley Chen (wisley.chen@quantatw.com) gerrit at coreboot.org
Wed Jan 18 04:31:09 CET 2017


Wisley Chen (wisley.chen at quantatw.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18163

-gerrit

commit 95987d678c0b23b9b12ec7fc84a183f43d6ddfda
Author: Wisley Chen <wisley.chen at quantatw.com>
Date:   Wed Jan 18 10:47:37 2017 +0800

    google/snappy: Use exported GPIOs and ACPI regulator for touchscreen
    
    ELAN touchscreen device expects firmware to export GPIOs and ACPI
    regulators for managing power to the device. Thus, provide the
    required ACPI elements for OS driver to properly manage this device.
    
    BUG=None
    BRANCH=None
    TEST=Verified that touchscreen works properly on boot-up and after
    suspend/resume.
    
    Change-Id: I78e0c35f60289afe338d140d90784a433ca534ae
    Signed-off-by: Wisley Chen <wisley.chen at quantatw.com>
---
 src/mainboard/google/reef/variants/snappy/devicetree.cb | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/mainboard/google/reef/variants/snappy/devicetree.cb b/src/mainboard/google/reef/variants/snappy/devicetree.cb
index e46483e..dfb414e 100644
--- a/src/mainboard/google/reef/variants/snappy/devicetree.cb
+++ b/src/mainboard/google/reef/variants/snappy/devicetree.cb
@@ -175,6 +175,16 @@ chip soc/intel/apollolake
 				register "desc" = ""ELAN Touchscreen""
 				register "irq" = "IRQ_EDGE_LOW(GPIO_21_IRQ)"
 				register "probed" = "1"
+				register "pwr_mgmt_type" = "GPIO_EXPORT"
+				register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36)"
+
+				chip drivers/generic/gpio_regulator
+					register "name" = ""vcc33""
+					register "gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_152)"
+					register "enabled_on_boot" = "1"
+					device generic 0 on end
+				end
+
 				device i2c 10 on end
 			end
 		end	# - I2C 3



More information about the coreboot-gerrit mailing list