[coreboot-gerrit] New patch to review for coreboot: nb/amd/ddr3: Make the maximum CDD a signed value
Timothy Pearson (tpearson@raptorengineering.com)
gerrit at coreboot.org
Wed Jan 18 01:30:30 CET 2017
Timothy Pearson (tpearson at raptorengineering.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18162
-gerrit
commit 4b3c007372a3bd2d872d092af26b20e0f8ca0402
Author: Timothy Pearson <tpearson at raptorengineering.com>
Date: Tue Jan 17 18:27:42 2017 -0600
nb/amd/ddr3: Make the maximum CDD a signed value
max_cdd_we_delta should be signed to allow for negative CDD.
Found-by: Coverity Scan #1347355
Change-Id: Iaccd1021680296d169c26c25e339f83fbd7cc065
Signed-off-by: Timothy Pearson <tpearson at raptorengineering.com>
---
src/northbridge/amd/amdmct/mct_ddr3/mct_d.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
index b64ad54..1ac91a1 100644
--- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
+++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
@@ -3027,7 +3027,7 @@ void fam15EnableTrainingMode(struct MCTStatStruc *pMCTstat,
/* Disable training mode */
uint8_t lane;
uint8_t dimm;
- uint16_t max_cdd_we_delta;
+ int16_t max_cdd_we_delta;
int16_t cdd_trwtto_we_delta;
uint8_t receiver;
uint8_t lane_count;
More information about the coreboot-gerrit
mailing list