[coreboot-gerrit] Patch set updated for coreboot: fsp_baytrail: Enable graphic init per default

Werner Zeh (werner.zeh@siemens.com) gerrit at coreboot.org
Fri Jan 13 06:34:03 CET 2017


Werner Zeh (werner.zeh at siemens.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18109

-gerrit

commit 57f1292e4246565faf22f4648ce9ee807747344e
Author: Werner Zeh <werner.zeh at siemens.com>
Date:   Thu Jan 12 06:29:04 2017 +0100

    fsp_baytrail: Enable graphic init per default
    
    Baytrail SoC has a bug where in some cases the DisplayPort can hang
    leading to a non-working display (it just stays black). To avoid this
    hang, a patch was introduced in 02/2016
    (1c3b1112fa - fsp_baytrail: Fix a possible hanging DisplayPort)
    but per default not switched on so that each
    mainboard can decide if it wants to use this patch or not.
    
    Recently a new case of this bug was reported by Benoit Sansoni
    (benoit.sansoni at kontron.com) and he requested to enable this fix per
    default as it costs him a lot of time to find the cause and even the
    already available fix in coreboot. To avoid this effort for someone
    else in the future we can enable this fix per default as no negative
    side effects are known and it is now tested at Siemens and at
    Kontron on different mainboards with success.
    
    As the goal is to enable this code permanently the config switch is not
    longer needed and is removed.
    
    Change-Id: I15bd682218d0dc887945cc91ee3e5488945a6355
    Signed-off-by: Werner Zeh <werner.zeh at siemens.com>
---
 src/mainboard/siemens/mc_tcu3/Kconfig   | 1 -
 src/soc/intel/fsp_baytrail/Kconfig      | 8 --------
 src/soc/intel/fsp_baytrail/Makefile.inc | 2 +-
 3 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/src/mainboard/siemens/mc_tcu3/Kconfig b/src/mainboard/siemens/mc_tcu3/Kconfig
index 5ff233d..6a3b3c4 100644
--- a/src/mainboard/siemens/mc_tcu3/Kconfig
+++ b/src/mainboard/siemens/mc_tcu3/Kconfig
@@ -29,7 +29,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select SOC_INTEL_FSP_BAYTRAIL_MD
 	select USE_BLOBS
 	select CBFS_AUTOGEN_ATTRIBUTES
-	select FSP_BAYTRAIL_GFX_INIT
 	select USE_SIEMENS_HWILIB
 
 config MAINBOARD_DIR
diff --git a/src/soc/intel/fsp_baytrail/Kconfig b/src/soc/intel/fsp_baytrail/Kconfig
index 689e625..549ea55 100644
--- a/src/soc/intel/fsp_baytrail/Kconfig
+++ b/src/soc/intel/fsp_baytrail/Kconfig
@@ -95,14 +95,6 @@ config VGA_BIOS_FILE
 	string
 	default "../intel/cpu/baytrail/vbios/Vga.dat" if VGA_BIOS
 
-config FSP_BAYTRAIL_GFX_INIT
-	default n
-	bool
-	help
-	  Enabling this option will activate graphics init code. With this init,
-	  the graphic power gate registers will be initialized before
-	  VBIOS is executed.
-
 config CPU_MICROCODE_HEADER_FILES
 	string
 	default "../intel/cpu/baytrail/microcode/M0130673322.h ../intel/cpu/baytrail/microcode/M0130679901.h ../intel/cpu/baytrail/microcode/M0230672228.h"
diff --git a/src/soc/intel/fsp_baytrail/Makefile.inc b/src/soc/intel/fsp_baytrail/Makefile.inc
index 6e16b42..f086665 100644
--- a/src/soc/intel/fsp_baytrail/Makefile.inc
+++ b/src/soc/intel/fsp_baytrail/Makefile.inc
@@ -57,7 +57,7 @@ ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smm.c
 
 ramstage-y += placeholders.c
 ramstage-y += i2c.c
-ramstage-$(CONFIG_FSP_BAYTRAIL_GFX_INIT) += gfx.c
+ramstage-y += gfx.c
 
 CPPFLAGS_common += -I$(src)/soc/intel/fsp_baytrail/include
 CPPFLAGS_common += -I$(src)/soc/intel/fsp_baytrail/fsp



More information about the coreboot-gerrit mailing list