[coreboot-gerrit] Patch merged into coreboot/master: soc/marvell/mvmap2315: Mark mvmap2315_reset() as noreturn

gerrit at coreboot.org gerrit at coreboot.org
Thu Jan 12 18:52:13 CET 2017


the following patch was just integrated into master:
commit 3051cd9265b8eb29742a66fc67db083289fa07e5
Author: Martin Roth <martinroth at google.com>
Date:   Wed Jan 11 10:57:09 2017 -0700

    soc/marvell/mvmap2315: Mark mvmap2315_reset() as noreturn
    
    mvmap2315_reset() is called from locations where we're checking for NULL
    pointers.  Because coverity can't tell from the code that the functions
    are not returning, it's showing errors of accessing pointers after
    we've determined that they're invalid.
    
    Mark it as noreturn, and add a loop in case the reset isn't on the
    next instruction.  This probably isn't needed, but shouldn't hurt.
    
    Found-by: Coverity Scan #1362809
    Change-Id: If93084629d5c2c8dc232558f2559b78b1ca5de7c
    Signed-off-by: Martin Roth <martinroth at google.com>
    Reviewed-on: https://review.coreboot.org/18103
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Nico Huber <nico.h at gmx.de>


See https://review.coreboot.org/18103 for details.

-gerrit



More information about the coreboot-gerrit mailing list