[coreboot-gerrit] Patch merged into coreboot/master: sb/intel/ibexpeak: Update debug code to match other chips

gerrit at coreboot.org gerrit at coreboot.org
Thu Jan 12 18:51:29 CET 2017


the following patch was just integrated into master:
commit 3e3b858888d735b45c2868fc50f6de53ca0f868a
Author: Martin Roth <martinroth at google.com>
Date:   Wed Jan 11 10:10:17 2017 -0700

    sb/intel/ibexpeak: Update debug code to match other chips
    
    Other chips dump tco_status here if it wasn't handled, which makes
    sense.
    
    tco_sts can't be zero here, because the call would have already returned
    if it were.  Also, dump_tco_status wouldn't print anything if tco_sts
    were zero.
    
    This will still only print the debug information if DEBUG_SMI is
    enabled in Kconfig, so in general, this change won't have much of an
    effect on anything.
    
    Found-by: Coverity Scan #1229598
    Change-Id: Id2c69a16817ba18dfa051f514138fbc04a2f7bee
    Signed-off-by: Martin Roth <martinroth at google.com>
    Reviewed-on: https://review.coreboot.org/18101
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Nico Huber <nico.h at gmx.de>


See https://review.coreboot.org/18101 for details.

-gerrit



More information about the coreboot-gerrit mailing list