[coreboot-gerrit] Patch set updated for coreboot: chromeos: fix build issues within sar.c

Robbie Zhang (robbie.zhang@intel.com) gerrit at coreboot.org
Tue Jan 10 19:37:34 CET 2017


Robbie Zhang (robbie.zhang at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18076

-gerrit

commit 23fad61dce9a708e9ed05a3e2884b026a1892e1c
Author: Robbie Zhang <robbie.zhang at intel.com>
Date:   Mon Jan 9 15:28:24 2017 -0800

    chromeos: fix build issues within sar.c
    
    Build issues were somehow overlooked in commit
    ed840023a84915ece4bc63edffef979926107d55:
    1. hexstrtobin is not defined (needs the lib.h);
    2. coreboot default compiler doesn't lile variable initialization
       within for loop.
    
    BUG=chrome-os-partner:60821
    TEST=Build and boot lars and reef
    
    Change-Id: Ie52c1f93eee7d739b8aaf59604875f179dff60d0
    Signed-off-by: Robbie Zhang <robbie.zhang at intel.com>
---
 src/vendorcode/google/chromeos/sar.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/vendorcode/google/chromeos/sar.c b/src/vendorcode/google/chromeos/sar.c
index 2b61e22..954492b 100644
--- a/src/vendorcode/google/chromeos/sar.c
+++ b/src/vendorcode/google/chromeos/sar.c
@@ -13,6 +13,7 @@
  * GNU General Public License for more details.
  */
 #include <console/console.h>
+#include <lib.h>
 #include <types.h>
 #include <string.h>
 #include <sar.h>
@@ -31,6 +32,7 @@ int get_wifi_sar_limits(struct wifi_sar_limits *sar_limits)
 				    sizeof(uint8_t)) * 2 + 1;
 	char wifi_sar_limit_str[buffer_size];
 	uint8_t bin_buffer[sizeof(struct wifi_sar_limits)];
+	int i;
 
 	/* Try to read the SAR limit entry from VPD */
 	if (!cros_vpd_gets(wifi_sar_limit_key, wifi_sar_limit_str,
@@ -52,7 +54,7 @@ int get_wifi_sar_limits(struct wifi_sar_limits *sar_limits)
 	}
 
 	/* Fill the sar_limits structure with the decoded data */
-	for (int i = 0; i < NUM_SAR_LIMITS; i++)
+	for (i = 0; i < NUM_SAR_LIMITS; i++)
 		memcpy(sar_limits->sar_limit[i],
 			&bin_buffer[BYTES_PER_SAR_LIMIT * i],
 			BYTES_PER_SAR_LIMIT);



More information about the coreboot-gerrit mailing list