[coreboot-gerrit] Patch set updated for coreboot: nb/i945/raminit.c: Use Makefile.inc instead of '#include rcven.c'

Arthur Heymans (arthur@aheymans.xyz) gerrit at coreboot.org
Tue Jan 10 19:21:50 CET 2017


Arthur Heymans (arthur at aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18087

-gerrit

commit 5d980e1d0b76e159d54644c576d880824bc09d0d
Author: Arthur Heymans <arthur at aheymans.xyz>
Date:   Tue Jan 10 14:26:23 2017 +0100

    nb/i945/raminit.c: Use Makefile.inc instead of '#include rcven.c'
    
    Change-Id: Ib86600b687c7002646ca82d5fa52121b6eafcd60
    Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
 src/northbridge/intel/i945/Makefile.inc | 1 +
 src/northbridge/intel/i945/raminit.c    | 3 ---
 src/northbridge/intel/i945/rcven.c      | 3 +++
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/northbridge/intel/i945/Makefile.inc b/src/northbridge/intel/i945/Makefile.inc
index 6b176c2..0e4fcfc 100644
--- a/src/northbridge/intel/i945/Makefile.inc
+++ b/src/northbridge/intel/i945/Makefile.inc
@@ -25,6 +25,7 @@ romstage-y += raminit.c
 romstage-y += early_init.c
 romstage-y += errata.c
 romstage-y += debug.c
+romstage-y += rcven.c
 
 smm-y += udelay.c
 
diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c
index a4a1eaf..a361ee7 100644
--- a/src/northbridge/intel/i945/raminit.c
+++ b/src/northbridge/intel/i945/raminit.c
@@ -22,7 +22,6 @@
 #include <pc80/mc146818rtc.h>
 #include <spd.h>
 #include <string.h>
-#include <arch/io.h>
 #include <halt.h>
 #include <lib.h>
 #include "raminit.h"
@@ -2743,8 +2742,6 @@ static void sdram_recover_receive_enable(void)
 	MCHBAR32(C1DRT1) = reg32;
 }
 
-#include "rcven.c"
-
 static void sdram_program_receive_enable(struct sys_info *sysinfo)
 {
 	MCHBAR32(REPC) |= (1 << 0);
diff --git a/src/northbridge/intel/i945/rcven.c b/src/northbridge/intel/i945/rcven.c
index f4d9315..a6aaefa 100644
--- a/src/northbridge/intel/i945/rcven.c
+++ b/src/northbridge/intel/i945/rcven.c
@@ -13,7 +13,10 @@
  * GNU General Public License for more details.
  */
 
+#include <console/console.h>
+#include <arch/io.h>
 #include "raminit.h"
+#include "i945.h"
 
 /**
  * sample the strobes signal



More information about the coreboot-gerrit mailing list