[coreboot-gerrit] New patch to review for coreboot: amd/mct/ddr3: Allow critical delay delta to go negative
Timothy Pearson (tpearson@raptorengineering.com)
gerrit at coreboot.org
Mon Jan 9 21:15:17 CET 2017
Timothy Pearson (tpearson at raptorengineering.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18071
-gerrit
commit 431d8235e2c395ba7c2129ec52eb94bca79b3907
Author: Timothy Pearson <tpearson at raptorengineering.com>
Date: Mon Jan 9 14:10:25 2017 -0600
amd/mct/ddr3: Allow critical delay delta to go negative
The critical delay delta was incorrectly specified as an
unsigned short. Use a signed short instead.
Found-by: Coverity Scan #1347355
Change-Id: I37d769afb8c8af85a0375ae459e9d4ab0adcca74
Signed-off-by: Timothy Pearson <tpearson at raptorengineering.com>
---
src/northbridge/amd/amdmct/mct_ddr3/mct_d.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
index 958b382..89e76eb 100644
--- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
+++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
@@ -3028,7 +3028,7 @@ void fam15EnableTrainingMode(struct MCTStatStruc *pMCTstat,
uint8_t lane;
uint8_t dimm;
uint16_t max_cdd_we_delta;
- uint16_t cdd_trwtto_we_delta;
+ int16_t cdd_trwtto_we_delta;
uint8_t receiver;
uint8_t lane_count;
uint8_t x4_present = 0;
More information about the coreboot-gerrit
mailing list