[coreboot-gerrit] New patch to review for coreboot: util/romcc: Ensure that bit shift is valid
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Mon Jan 2 21:44:27 CET 2017
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18020
-gerrit
commit 8524b01ee26cad80295bc0c1b433626bdcd12a75
Author: Patrick Georgi <pgeorgi at chromium.org>
Date: Mon Jan 2 21:24:50 2017 +0100
util/romcc: Ensure that bit shift is valid
Change-Id: Idbe147c1217f793b0360a752383203c658b0bdce
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Found-by: Coverity Scan #1287090
---
util/romcc/romcc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/romcc/romcc.c b/util/romcc/romcc.c
index 3cc72a7..517ad2a 100644
--- a/util/romcc/romcc.c
+++ b/util/romcc/romcc.c
@@ -14250,7 +14250,7 @@ static void compute_closure_variables(struct compile_state *state,
}
/* Find the lowest unused index value */
for(index = 0; index < MAX_INDICIES; index++) {
- if (!(used_indicies & (1 << index))) {
+ if (!(used_indicies & ((uint64_t)1 << index))) {
break;
}
}
More information about the coreboot-gerrit
mailing list