[coreboot-gerrit] New patch to review for coreboot: buildgcc: Remove quotes around a $CC call

Nico Huber (nico.h@gmx.de) gerrit at coreboot.org
Mon Jan 2 20:55:42 CET 2017


Nico Huber (nico.h at gmx.de) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18018

-gerrit

commit 8ec36be38b735c7b1e76010bec62d8a344c4dd86
Author: Nico Huber <nico.h at gmx.de>
Date:   Mon Jan 2 20:51:28 2017 +0100

    buildgcc: Remove quotes around a $CC call
    
    If we use ccache we have to interpret spaces in $CC as separation
    characters. The downside is that we can't support spaces in the
    compiler's path. But, well...
    
    Change-Id: I4e6e6324389354669a755f570083a40ff00b1bbf
    Signed-off-by: Nico Huber <nico.h at gmx.de>
---
 util/crossgcc/buildgcc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 273f921..0dfca26 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -517,7 +517,7 @@ set_hostcflags_from_gmp() {
 build_GMP() {
 	# Check if GCC enables `-pie` by default (possible since GCC 6).
 	# We need PIC in all static libraries then.
-	if "${CC}" -dumpspecs 2>/dev/null | grep -q '[{;][[:space:]]*:-pie\>'
+	if $CC -dumpspecs 2>/dev/null | grep -q '[{;][[:space:]]*:-pie\>'
 	then
 		OPTIONS="$OPTIONS --with-pic"
 	fi



More information about the coreboot-gerrit mailing list