[coreboot-gerrit] New patch to review for coreboot: mainboard/lenovo: Power off USB and mute audio before entering S3

Nicola Corna (nicola@corna.info) gerrit at coreboot.org
Wed Feb 22 17:47:59 CET 2017


Nicola Corna (nicola at corna.info) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18464

-gerrit

commit a8c4f61a71fc3a327cd7a9e9944174f6c6d7c3cc
Author: Nicola Corna <nicola at corna.info>
Date:   Wed Feb 22 16:52:29 2017 +0100

    mainboard/lenovo: Power off USB and mute audio before entering S3
    
    The USB ports were still powered during S3, possibly leading to a
    higher power consumption. Note that, when the USB Always on
    feature is enabled, the USB ports are always powered, regardless
    of the USBP state.
    
    The audio has been disabled as well, as it might consume some
    power or generate some noise.
    
    Both the USB power and the audio are reenabled by coreboot during
    the poweron.
    
    Change-Id: If0431b1315fffef2e372e7023f830a66bb7fddae
    Signed-off-by: Nicola Corna <nicola at corna.info>
---
 src/mainboard/lenovo/l520/acpi/platform.asl  | 2 ++
 src/mainboard/lenovo/t400/acpi/platform.asl  | 2 ++
 src/mainboard/lenovo/t420/acpi/platform.asl  | 2 ++
 src/mainboard/lenovo/t420s/acpi/platform.asl | 2 ++
 src/mainboard/lenovo/t430s/acpi/platform.asl | 2 ++
 src/mainboard/lenovo/t520/acpi/platform.asl  | 2 ++
 src/mainboard/lenovo/t530/acpi/platform.asl  | 2 ++
 src/mainboard/lenovo/x200/acpi/platform.asl  | 2 ++
 src/mainboard/lenovo/x220/acpi/platform.asl  | 2 ++
 src/mainboard/lenovo/x230/acpi/platform.asl  | 2 ++
 10 files changed, 20 insertions(+)

diff --git a/src/mainboard/lenovo/l520/acpi/platform.asl b/src/mainboard/lenovo/l520/acpi/platform.asl
index 432ed23..c7aea62 100644
--- a/src/mainboard/lenovo/l520/acpi/platform.asl
+++ b/src/mainboard/lenovo/l520/acpi/platform.asl
@@ -24,5 +24,7 @@ Method(_WAK,1)
 
 Method(_PTS,1)
 {
+	\_SB.PCI0.LPCB.EC.MUTE(1)
+	\_SB.PCI0.LPCB.EC.USBP(0)
 	\_SB.PCI0.LPCB.EC.RADI(0)
 }
diff --git a/src/mainboard/lenovo/t400/acpi/platform.asl b/src/mainboard/lenovo/t400/acpi/platform.asl
index f60752c..5c6f968 100644
--- a/src/mainboard/lenovo/t400/acpi/platform.asl
+++ b/src/mainboard/lenovo/t400/acpi/platform.asl
@@ -22,6 +22,8 @@ Method(_PTS,1)
 {
 	// Call a trap so SMI can prepare for Sleep as well.
 	// TRAP(0x55)
+	\_SB.PCI0.LPCB.EC.MUTE(1)
+	\_SB.PCI0.LPCB.EC.USBP(0)
 	\_SB.PCI0.LPCB.EC.RADI(0)
 }
 
diff --git a/src/mainboard/lenovo/t420/acpi/platform.asl b/src/mainboard/lenovo/t420/acpi/platform.asl
index 2ba5b20..6f26c5a 100644
--- a/src/mainboard/lenovo/t420/acpi/platform.asl
+++ b/src/mainboard/lenovo/t420/acpi/platform.asl
@@ -19,6 +19,8 @@
 
 Method(_PTS,1)
 {
+	\_SB.PCI0.LPCB.EC.MUTE(1)
+	\_SB.PCI0.LPCB.EC.USBP(0)
 	\_SB.PCI0.LPCB.EC.RADI(0)
 }
 
diff --git a/src/mainboard/lenovo/t420s/acpi/platform.asl b/src/mainboard/lenovo/t420s/acpi/platform.asl
index 2ba5b20..6f26c5a 100644
--- a/src/mainboard/lenovo/t420s/acpi/platform.asl
+++ b/src/mainboard/lenovo/t420s/acpi/platform.asl
@@ -19,6 +19,8 @@
 
 Method(_PTS,1)
 {
+	\_SB.PCI0.LPCB.EC.MUTE(1)
+	\_SB.PCI0.LPCB.EC.USBP(0)
 	\_SB.PCI0.LPCB.EC.RADI(0)
 }
 
diff --git a/src/mainboard/lenovo/t430s/acpi/platform.asl b/src/mainboard/lenovo/t430s/acpi/platform.asl
index 2ba5b20..6f26c5a 100644
--- a/src/mainboard/lenovo/t430s/acpi/platform.asl
+++ b/src/mainboard/lenovo/t430s/acpi/platform.asl
@@ -19,6 +19,8 @@
 
 Method(_PTS,1)
 {
+	\_SB.PCI0.LPCB.EC.MUTE(1)
+	\_SB.PCI0.LPCB.EC.USBP(0)
 	\_SB.PCI0.LPCB.EC.RADI(0)
 }
 
diff --git a/src/mainboard/lenovo/t520/acpi/platform.asl b/src/mainboard/lenovo/t520/acpi/platform.asl
index 2ba5b20..6f26c5a 100644
--- a/src/mainboard/lenovo/t520/acpi/platform.asl
+++ b/src/mainboard/lenovo/t520/acpi/platform.asl
@@ -19,6 +19,8 @@
 
 Method(_PTS,1)
 {
+	\_SB.PCI0.LPCB.EC.MUTE(1)
+	\_SB.PCI0.LPCB.EC.USBP(0)
 	\_SB.PCI0.LPCB.EC.RADI(0)
 }
 
diff --git a/src/mainboard/lenovo/t530/acpi/platform.asl b/src/mainboard/lenovo/t530/acpi/platform.asl
index 3e9225c..9cd327a 100644
--- a/src/mainboard/lenovo/t530/acpi/platform.asl
+++ b/src/mainboard/lenovo/t530/acpi/platform.asl
@@ -19,6 +19,8 @@
 
 Method(_PTS,1)
 {
+	\_SB.PCI0.LPCB.EC.MUTE(1)
+	\_SB.PCI0.LPCB.EC.USBP(0)
 	\_SB.PCI0.LPCB.EC.RADI(0)
 }
 
diff --git a/src/mainboard/lenovo/x200/acpi/platform.asl b/src/mainboard/lenovo/x200/acpi/platform.asl
index f60752c..5c6f968 100644
--- a/src/mainboard/lenovo/x200/acpi/platform.asl
+++ b/src/mainboard/lenovo/x200/acpi/platform.asl
@@ -22,6 +22,8 @@ Method(_PTS,1)
 {
 	// Call a trap so SMI can prepare for Sleep as well.
 	// TRAP(0x55)
+	\_SB.PCI0.LPCB.EC.MUTE(1)
+	\_SB.PCI0.LPCB.EC.USBP(0)
 	\_SB.PCI0.LPCB.EC.RADI(0)
 }
 
diff --git a/src/mainboard/lenovo/x220/acpi/platform.asl b/src/mainboard/lenovo/x220/acpi/platform.asl
index 3e9225c..9cd327a 100644
--- a/src/mainboard/lenovo/x220/acpi/platform.asl
+++ b/src/mainboard/lenovo/x220/acpi/platform.asl
@@ -19,6 +19,8 @@
 
 Method(_PTS,1)
 {
+	\_SB.PCI0.LPCB.EC.MUTE(1)
+	\_SB.PCI0.LPCB.EC.USBP(0)
 	\_SB.PCI0.LPCB.EC.RADI(0)
 }
 
diff --git a/src/mainboard/lenovo/x230/acpi/platform.asl b/src/mainboard/lenovo/x230/acpi/platform.asl
index 3e9225c..9cd327a 100644
--- a/src/mainboard/lenovo/x230/acpi/platform.asl
+++ b/src/mainboard/lenovo/x230/acpi/platform.asl
@@ -19,6 +19,8 @@
 
 Method(_PTS,1)
 {
+	\_SB.PCI0.LPCB.EC.MUTE(1)
+	\_SB.PCI0.LPCB.EC.USBP(0)
 	\_SB.PCI0.LPCB.EC.RADI(0)
 }
 



More information about the coreboot-gerrit mailing list