[coreboot-gerrit] Patch merged into coreboot/master: nb/intel/x4x: Fix raminit on reset path

gerrit at coreboot.org gerrit at coreboot.org
Fri Feb 17 23:44:09 CET 2017


the following patch was just integrated into master:
commit 97e13d84c30c308c3b2bc629b38e6bcc9565dc3a
Author: Arthur Heymans <arthur at aheymans.xyz>
Date:   Wed Nov 30 18:40:38 2016 +0100

    nb/intel/x4x: Fix raminit on reset path
    
    Previously the raminit failed on hot reset and to work around this
    issue it unconditionally did a cold reset.
    
    This has the following issues:
    * it's slow;
    * when the OS issues a hot reset some disk drives expect their 5V
      power supply to remain on, which gets cut off by a cold reset,
      causing data corruption.
    
    To fix this some steps in raminit must be ommited on the reset path.
    This includes receive enable calibration.
    To achieve this it stores receive enable results in RTC nvram for them
    to be rewritten on the resume path.
    Note: The same thing needs to be done on the S3 resume path.
    
    Calling a hot reset after raminit "outb(0x6, 0cf9)" works.
    
    Change-Id: I6601dd90aebd071a0de7cec070487b0f9845bc30
    Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
    Reviewed-on: https://review.coreboot.org/18009
    Tested-by: build bot (Jenkins)
    Reviewed-by: Nico Huber <nico.h at gmx.de>


See https://review.coreboot.org/18009 for details.

-gerrit



More information about the coreboot-gerrit mailing list