[coreboot-gerrit] New patch to review for coreboot: Revert "google/pyro: remove Wacom touchscreen probed flag"
Kevin Chiu (Kevin.Chiu@quantatw.com)
gerrit at coreboot.org
Fri Feb 3 20:59:28 CET 2017
Kevin Chiu (Kevin.Chiu at quantatw.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18291
-gerrit
commit 88c47fb7a283fc717f7c69911a090887be6f9f93
Author: Kevin Chiu <Kevin.Chiu at quantatw.com>
Date: Sat Feb 4 03:55:01 2017 +0800
Revert "google/pyro: remove Wacom touchscreen probed flag"
This reverts commit 1099c665091b64bff3c01234826e8c7640a7b8f6
Reason for revert:
Pyro has two touchscreen sources: WACOM/ELAN.
It will not have both touchscreen IC in one system at the same time.
So the "probed" property of WACOM i2c device is mandatory to set for kernel
to know whether it exists before driver initializes it.
Otherwise in ELAN case, when driver fails to init WACOM i2c device, ACPI _OFF
will be invoked to set GPIO#152 low to cut off power.
BUG=chrome-os-partner:62371
BRANCH=reef
TEST=emerge-pyro coreboot
Change-Id: I30f467bd8720d959686dc14f7877e6bc11ea6213
Signed-off-by: Kevin Chiu <Kevin.Chiu at quantatw.com>
---
src/mainboard/google/reef/variants/pyro/devicetree.cb | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mainboard/google/reef/variants/pyro/devicetree.cb b/src/mainboard/google/reef/variants/pyro/devicetree.cb
index 72ad57c..c36d19d 100644
--- a/src/mainboard/google/reef/variants/pyro/devicetree.cb
+++ b/src/mainboard/google/reef/variants/pyro/devicetree.cb
@@ -187,6 +187,7 @@ chip soc/intel/apollolake
.cid = PNP0C50_CID,
.desc = WCOM_TS_DESC,
.irq = IRQ_LEVEL_LOW(GPIO_21_IRQ),
+ .probed = 1,
.reset_gpio = ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36),
.reset_delay_ms = 20,
.enable_gpio = ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_152),
More information about the coreboot-gerrit
mailing list