[coreboot-gerrit] Change in coreboot[master]: mb/google/fizz: Override IccMax settings

[Kane Chen (Code Review)]

Kane Chen has posted comments on this change. ( https://review.coreboot.org/23020 )

Change subject: mb/google/fizz: Override IccMax settings
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/23020/1/src/mainboard/google/fizz/ramstage.c
File src/mainboard/google/fizz/ramstage.c:

https://review.coreboot.org/#/c/23020/1/src/mainboard/google/fizz/ramstage.c@21
PS1, Line 21: static void mainboard_setup_iccmax(config_t *conf)
should we move this code to skylake common code rather that board specific code?
thanks.


https://review.coreboot.org/#/c/23020/1/src/mainboard/google/fizz/ramstage.c@41
PS1, Line 41: if 
else if
thanks.



-- 
To view, visit https://review.coreboot.org/23020
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I32ffe0cb73981850005b20fefb6664cfab74fbca
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 1
Gerrit-Owner: Gaggery Tsai <gaggery.tsai at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Kane Chen <kane.chen at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 28 Dec 2017 09:23:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171228/2f2ba8ae/attachment.html>