<p><a href="https://review.coreboot.org/23020">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/23020/1/src/mainboard/google/fizz/ramstage.c">File src/mainboard/google/fizz/ramstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23020/1/src/mainboard/google/fizz/ramstage.c@21">Patch Set #1, Line 21:</a> <code style="font-family:monospace,monospace">static void mainboard_setup_iccmax(config_t *conf)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">should we move this code to skylake common code rather that board specific code?<br>thanks.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23020/1/src/mainboard/google/fizz/ramstage.c@41">Patch Set #1, Line 41:</a> <code style="font-family:monospace,monospace">if </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">else if<br>thanks.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/23020">change 23020</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23020"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I32ffe0cb73981850005b20fefb6664cfab74fbca </div>
<div style="display:none"> Gerrit-Change-Number: 23020 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Gaggery Tsai <gaggery.tsai@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kane Chen <kane.chen@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 28 Dec 2017 09:23:49 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>