[coreboot-gerrit] Change in coreboot[master]: superio/ite: add missing pnp_conf_mode fields in ops struct

[Felix Held (Code Review)]

Felix Held has uploaded this change for review. ( https://review.coreboot.org/23004


Change subject: superio/ite: add missing pnp_conf_mode fields in ops struct
......................................................................

superio/ite: add missing pnp_conf_mode fields in ops struct

This fixes the bug that the LDNs on the affected SIO chips didn't get
configured, since the config mode wasn't entered.

Change-Id: Ic468847571e164e4e1280428f08fc067b724464e
Signed-off-by: Felix Held <felix-coreboot at felixheld.de>
---
M src/superio/ite/it8671f/superio.c
M src/superio/ite/it8718f/superio.c
M src/superio/ite/it8721f/superio.c
3 files changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/23004/1

diff --git a/src/superio/ite/it8671f/superio.c b/src/superio/ite/it8671f/superio.c
index f69a06c..7e09fda 100644
--- a/src/superio/ite/it8671f/superio.c
+++ b/src/superio/ite/it8671f/superio.c
@@ -45,6 +45,7 @@
 	.enable_resources = pnp_enable_resources,
 	.enable           = pnp_enable,
 	.init             = init,
+	.ops_pnp_mode     = &pnp_conf_mode_870155_aa,
 };
 
 /* TODO: FDC, PP, KBCM. */
diff --git a/src/superio/ite/it8718f/superio.c b/src/superio/ite/it8718f/superio.c
index b4ac679..e1b8a8f 100644
--- a/src/superio/ite/it8718f/superio.c
+++ b/src/superio/ite/it8718f/superio.c
@@ -59,6 +59,7 @@
 	.enable_resources = pnp_enable_resources,
 	.enable           = pnp_enable,
 	.init             = init,
+	.ops_pnp_mode     = &pnp_conf_mode_870155_aa,
 };
 
 /* TODO: IR. */
diff --git a/src/superio/ite/it8721f/superio.c b/src/superio/ite/it8721f/superio.c
index 9838659..e80d34f 100644
--- a/src/superio/ite/it8721f/superio.c
+++ b/src/superio/ite/it8721f/superio.c
@@ -50,6 +50,7 @@
 	.enable_resources = pnp_enable_resources,
 	.enable           = pnp_enable,
 	.init             = init,
+	.ops_pnp_mode     = &pnp_conf_mode_870155_aa,
 };
 
 /* TODO: FDC, PP, EC, KBCM, IR. */

-- 
To view, visit https://review.coreboot.org/23004
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic468847571e164e4e1280428f08fc067b724464e
Gerrit-Change-Number: 23004
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot at felixheld.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171227/b2b036a1/attachment-0001.html>