<p>Felix Held has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23004">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">superio/ite: add missing pnp_conf_mode fields in ops struct<br><br>This fixes the bug that the LDNs on the affected SIO chips didn't get<br>configured, since the config mode wasn't entered.<br><br>Change-Id: Ic468847571e164e4e1280428f08fc067b724464e<br>Signed-off-by: Felix Held <felix-coreboot@felixheld.de><br>---<br>M src/superio/ite/it8671f/superio.c<br>M src/superio/ite/it8718f/superio.c<br>M src/superio/ite/it8721f/superio.c<br>3 files changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/23004/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/superio/ite/it8671f/superio.c b/src/superio/ite/it8671f/superio.c</span><br><span>index f69a06c..7e09fda 100644</span><br><span>--- a/src/superio/ite/it8671f/superio.c</span><br><span>+++ b/src/superio/ite/it8671f/superio.c</span><br><span>@@ -45,6 +45,7 @@</span><br><span>         .enable_resources = pnp_enable_resources,</span><br><span>    .enable           = pnp_enable,</span><br><span>      .init             = init,</span><br><span style="color: hsl(120, 100%, 40%);">+     .ops_pnp_mode     = &pnp_conf_mode_870155_aa,</span><br><span> };</span><br><span> </span><br><span> /* TODO: FDC, PP, KBCM. */</span><br><span>diff --git a/src/superio/ite/it8718f/superio.c b/src/superio/ite/it8718f/superio.c</span><br><span>index b4ac679..e1b8a8f 100644</span><br><span>--- a/src/superio/ite/it8718f/superio.c</span><br><span>+++ b/src/superio/ite/it8718f/superio.c</span><br><span>@@ -59,6 +59,7 @@</span><br><span>       .enable_resources = pnp_enable_resources,</span><br><span>    .enable           = pnp_enable,</span><br><span>      .init             = init,</span><br><span style="color: hsl(120, 100%, 40%);">+     .ops_pnp_mode     = &pnp_conf_mode_870155_aa,</span><br><span> };</span><br><span> </span><br><span> /* TODO: IR. */</span><br><span>diff --git a/src/superio/ite/it8721f/superio.c b/src/superio/ite/it8721f/superio.c</span><br><span>index 9838659..e80d34f 100644</span><br><span>--- a/src/superio/ite/it8721f/superio.c</span><br><span>+++ b/src/superio/ite/it8721f/superio.c</span><br><span>@@ -50,6 +50,7 @@</span><br><span>  .enable_resources = pnp_enable_resources,</span><br><span>    .enable           = pnp_enable,</span><br><span>      .init             = init,</span><br><span style="color: hsl(120, 100%, 40%);">+     .ops_pnp_mode     = &pnp_conf_mode_870155_aa,</span><br><span> };</span><br><span> </span><br><span> /* TODO: FDC, PP, EC, KBCM, IR. */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23004">change 23004</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23004"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic468847571e164e4e1280428f08fc067b724464e </div>
<div style="display:none"> Gerrit-Change-Number: 23004 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de> </div>