[coreboot-gerrit] Change in coreboot[master]: nb/intel/x4x/raminit: Support programming initials DD3 DLL setting
Arthur Heymans (Code Review)
gerrit at coreboot.org
Wed Dec 27 00:21:36 CET 2017
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/22993
Change subject: nb/intel/x4x/raminit: Support programming initials DD3 DLL setting
......................................................................
nb/intel/x4x/raminit: Support programming initials DD3 DLL setting
Change-Id: I67e48b4ae6f2076399133ba7b98ab1dfc0e0ab08
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/northbridge/intel/x4x/raminit_ddr23.c
1 file changed, 205 insertions(+), 59 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/22993/1
diff --git a/src/northbridge/intel/x4x/raminit_ddr23.c b/src/northbridge/intel/x4x/raminit_ddr23.c
index 5ad4453..a4b11d5 100644
--- a/src/northbridge/intel/x4x/raminit_ddr23.c
+++ b/src/northbridge/intel/x4x/raminit_ddr23.c
@@ -583,7 +583,8 @@
MCHBAR16(0x400*i + 0x25b) = ((s->selected_timings.tRP + trpmod) << 9) |
s->selected_timings.tRFC;
- MCHBAR16(0x400*i + 0x260) = (MCHBAR16(0x400*i + 0x260) & ~0x3fe) | (100 << 1);
+ MCHBAR16(0x400*i + 0x260) = (MCHBAR16(0x400*i + 0x260) & ~0x3fe)
+ | ((s->spd_type == DDR2 ? 100 : 256) << 1);
MCHBAR8(0x400*i + 0x264) = 0xff;
MCHBAR8(0x400*i + 0x25d) = (MCHBAR8(0x400*i + 0x25d) & ~0x3f) |
s->selected_timings.tRAS;
@@ -636,18 +637,32 @@
MCHBAR8(0x400*i + 0x24c) = MCHBAR8(0x400*i + 0x24c) & ~0x3;
reg16 = 0;
- switch (s->selected_timings.mem_clk) {
- default:
- case MEM_CLOCK_667MHz:
- reg16 = 0x99;
- break;
- case MEM_CLOCK_800MHz:
- if (s->selected_timings.CAS == 5)
- reg16 = 0x19a;
- else if (s->selected_timings.CAS == 6)
- reg16 = 0x9a;
- break;
+ if (s->spd_type == DDR2) {
+ switch (s->selected_timings.mem_clk) {
+ default:
+ case MEM_CLOCK_667MHz:
+ reg16 = 0x99;
+ break;
+ case MEM_CLOCK_800MHz:
+ if (s->selected_timings.CAS == 5)
+ reg16 = 0x19a;
+ else if (s->selected_timings.CAS == 6)
+ reg16 = 0x9a;
+ break;
+ }
+ } else { /* DDR3 */
+ switch (s->selected_timings.mem_clk) {
+ default:
+ case MEM_CLOCK_800MHz:
+ case MEM_CLOCK_1066MHz:
+ reg16 = 1;
+ break;
+ case MEM_CLOCK_1333MHz:
+ reg16 = 2;
+ break;
+ }
}
+
reg16 &= 0x7;
reg16 += twl + 9;
reg16 <<= 10;
@@ -683,6 +698,13 @@
MCHBAR8(0x12d) = (MCHBAR8(0x12d) & ~0xf) | reg8;
MCHBAR8(0x12f) = 0x4c;
reg32 = (1 << 31) | (0x80 << 14) | (1 << 13) | (0xa << 9);
+ if (s->spd_type == DDR3) {
+ MCHBAR8(0x114) = 0x42;
+ reg16 = (512 - MAX(5, s->selected_timings.tRFC +
+ 10000 / ddr2ps[s->selected_timings.mem_clk])) / 2;
+ reg16 &= 0x1ff;
+ reg32 = (reg16 << 22) | (0x80 << 14) | (0xa << 9);
+ }
MCHBAR32(0x6c0) = (MCHBAR32(0x6c0) & ~0xffffff00) | reg32;
MCHBAR8(0x6c4) = (MCHBAR8(0x6c4) & ~0x7) | 0x2;
}
@@ -693,6 +715,9 @@
u16 reg16 = 0;
u32 reg32 = 0;
+ const u8 rank2clken[8] = { 0x04, 0x01, 0x20, 0x08, 0x01, 0x04,
+ 0x08, 0x10 };
+
MCHBAR16(0x180) = (MCHBAR16(0x180) & ~0x7e06) | 0xc04;
MCHBAR16(0x182) = (MCHBAR16(0x182) & ~0x3ff) | 0xc8;
MCHBAR16(0x18a) = (MCHBAR16(0x18a) & ~0x1f1f) | 0x0f0f;
@@ -701,11 +726,15 @@
switch (s->selected_timings.mem_clk) {
default:
case MEM_CLOCK_667MHz:
+ case MEM_CLOCK_1333MHz:
reg16 = (0xa << 9) | 0xa;
break;
case MEM_CLOCK_800MHz:
reg16 = (0x9 << 9) | 0x9;
break;
+ case MEM_CLOCK_1066MHz:
+ reg16 = (0x7 << 9) | 0x7;
+ break;
}
MCHBAR16(0x19c) = (MCHBAR16(0x19c) & ~0x1e0f) | reg16;
MCHBAR16(0x19c) = (MCHBAR16(0x19c) & ~0x2030) | 0x2010;
@@ -729,14 +758,26 @@
udelay(1); // 533ns
// ME related
- MCHBAR32(0x1a0) = (MCHBAR32(0x1a0) & ~0x7ffffff) | 0x551803;
+ MCHBAR32(0x1a0) = (MCHBAR32(0x1a0) & ~0x7ffffff)
+ | (s->spd_type == DDR2 ? 0x551803 : 0x555801);
MCHBAR16(0x1b4) = MCHBAR16(0x1b4) & ~0x800;
- MCHBAR8(0x1a8) = MCHBAR8(0x1a8) | 0xf0;
+ if (s->spd_type == DDR2) {
+ MCHBAR8(0x1a8) = MCHBAR8(0x1a8) | 0xf0;
+ } else { /* DDR3 */
+ reg8 = 0x9; /* 0x9 << 4 ?? */
+ if (s->dimms[0].ranks == 2)
+ reg8 &= ~0x80;
+ if (s->dimms[3].ranks == 2)
+ reg8 &= ~0x10;
+ MCHBAR8(0x1a8) = (MCHBAR8(0x1a8) & ~0xf0) | reg8;
+ }
FOR_EACH_CHANNEL(i) {
reg16 = 0;
- MCHBAR16(0x400*i + 0x59c) = MCHBAR16(0x400*i + 0x59c) & ~0x3000;
+ if ((s->spd_type == DDR3) && (i == 0))
+ reg16 = (0x3 << 12);
+ MCHBAR16(0x400*i + 0x59c) = (MCHBAR16(0x400*i + 0x59c) & ~0x3000) | reg16;
reg32 = 0;
FOR_EACH_RANK_IN_CHANNEL(r) {
@@ -747,30 +788,49 @@
MCHBAR32(0x400*i + 0x59c) = (MCHBAR32(0x400*i + 0x59c) & ~0xfff) | reg32;
MCHBAR8(0x400*i + 0x594) = MCHBAR8(0x400*i + 0x594) & ~1;
- if (!CHANNEL_IS_POPULATED(s->dimms, i)) {
- printk(BIOS_DEBUG, "No dimms in channel %d\n", i);
- reg8 = 0x3f;
- } else if (ONLY_DIMMA_IS_POPULATED(s->dimms, i)) {
- printk(BIOS_DEBUG, "DimmA populated only in channel %d\n", i);
- reg8 = 0x38;
- } else if (ONLY_DIMMB_IS_POPULATED(s->dimms, i)) {
- printk(BIOS_DEBUG, "DimmB populated only in channel %d\n", i);
- reg8 = 0x7;
- } else if (BOTH_DIMMS_ARE_POPULATED(s->dimms, i)) {
- printk(BIOS_DEBUG, "Both dimms populated in channel %d\n", i);
- reg8 = 0;
- } else {
- die("Unhandled case\n");
+ if (s->spd_type == DDR2) {
+ if (!CHANNEL_IS_POPULATED(s->dimms, i)) {
+ printk(BIOS_DEBUG,
+ "No dimms in channel %d\n", i);
+ reg8 = 0x3f;
+ } else if (ONLY_DIMMA_IS_POPULATED(s->dimms, i)) {
+ printk(BIOS_DEBUG,
+ "DimmA populated only in channel %d\n",
+ i);
+ reg8 = 0x38;
+ } else if (ONLY_DIMMB_IS_POPULATED(s->dimms, i)) {
+ printk(BIOS_DEBUG,
+ "DimmB populated only in channel %d\n",
+ i);
+ reg8 = 0x7;
+ } else if (BOTH_DIMMS_ARE_POPULATED(s->dimms, i)) {
+ printk(BIOS_DEBUG,
+ "Both dimms populated in channel %d\n",
+ i);
+ reg8 = 0;
+ } else {
+ die("Unhandled case\n");
+ }
+ MCHBAR32(0x400*i + 0x5a0) = (MCHBAR32(0x400*i + 0x5a0)
+ & ~0x3f000000) | ((u32)(reg8 << 24));
+
+ } else { /* DDR3 */
+ FOR_EACH_POPULATED_RANK_IN_CHANNEL(s->dimms, i, r) {
+ MCHBAR8(0x400 * i + 0x5a0 + 3) = MCHBAR8(0x400 * i + 0x5a0 + 3)
+ & ~rank2clken[r + i * 4];
+ }
}
//reg8 = 0x00; // FIXME don't switch on all clocks anyway
-
- MCHBAR32(0x400*i + 0x5a0) = (MCHBAR32(0x400*i + 0x5a0) & ~0x3f000000) |
- ((u32)(reg8 << 24));
} // END EACH CHANNEL
- MCHBAR8(0x1a8) = MCHBAR8(0x1a8) | 1;
- MCHBAR8(0x1a8) = MCHBAR8(0x1a8) & ~0x4;
+ if (s->spd_type == DDR2) {
+ MCHBAR8(0x1a8) = MCHBAR8(0x1a8) | 1;
+ MCHBAR8(0x1a8) = MCHBAR8(0x1a8) & ~0x4;
+ } else { /* DDR3 */
+ MCHBAR8(0x1a8) = MCHBAR8(0x1a8) & ~1;
+ MCHBAR8(0x1a8) = MCHBAR8(0x1a8) | 0x4;
+ }
// Update DLL timing
MCHBAR8(0x1a4) = MCHBAR8(0x1a4) & ~0x80;
@@ -780,12 +840,16 @@
FOR_EACH_POPULATED_CHANNEL(s->dimms, i) {
MCHBAR16(0x400*i + 0x5f0) = (MCHBAR16(0x400*i + 0x5f0) & ~0x3fc) | 0x3fc;
MCHBAR32(0x400*i + 0x5fc) = MCHBAR32(0x400*i + 0x5fc) & ~0xcccccccc;
- MCHBAR8(0x400*i + 0x5d9) = (MCHBAR8(0x400*i + 0x5d9) & ~0xf0) | 0x70;
- MCHBAR16(0x400*i + 0x590) = (MCHBAR16(0x400*i + 0x590) & ~0xffff) | 0x5555;
+ MCHBAR8(0x400*i + 0x5d9) = (MCHBAR8(0x400*i + 0x5d9) & ~0xf0)
+ | (s->spd_type == DDR2 ? 0x70 : 0x60);
+ MCHBAR16(0x400*i + 0x590) = (MCHBAR16(0x400*i + 0x590) & ~0xffff)
+ | (s->spd_type == DDR2 ? 0x5555 : 0xa955);
}
FOR_EACH_POPULATED_CHANNEL(s->dimms, i) {
- if (s->selected_timings.mem_clk == MEM_CLOCK_667MHz) {
+ switch(s->selected_timings.mem_clk) {
+ default: /* Should not happen */
+ case MEM_CLOCK_667MHz:
clkset0(i, &default_ddr2_667_ctrl[CLKSET0]);
clkset1(i, &default_ddr2_667_ctrl[CLKSET1]);
ctrlset0(i, &default_ddr2_667_ctrl[CTRL0]);
@@ -793,14 +857,65 @@
ctrlset2(i, &default_ddr2_667_ctrl[CTRL2]);
ctrlset3(i, &default_ddr2_667_ctrl[CTRL3]);
cmdset(i, &default_ddr2_667_ctrl[CMD]);
- } else {
- clkset0(i, &default_ddr2_800_ctrl[CLKSET0]);
- clkset1(i, &default_ddr2_800_ctrl[CLKSET1]);
- ctrlset0(i, &default_ddr2_800_ctrl[CTRL0]);
- ctrlset1(i, &default_ddr2_800_ctrl[CTRL1]);
- ctrlset2(i, &default_ddr2_800_ctrl[CTRL2]);
- ctrlset3(i, &default_ddr2_800_ctrl[CTRL3]);
- cmdset(i, &default_ddr2_800_ctrl[CMD]);
+ break;
+ case MEM_CLOCK_800MHz:
+ if (s->spd_type == DDR2) {
+ clkset0(i, &default_ddr2_800_ctrl[CLKSET0]);
+ clkset1(i, &default_ddr2_800_ctrl[CLKSET1]);
+ ctrlset0(i, &default_ddr2_800_ctrl[CTRL0]);
+ ctrlset1(i, &default_ddr2_800_ctrl[CTRL1]);
+ ctrlset2(i, &default_ddr2_800_ctrl[CTRL2]);
+ ctrlset3(i, &default_ddr2_800_ctrl[CTRL3]);
+ cmdset(i, &default_ddr2_800_ctrl[CMD]);
+ } else { /* DDR3 */
+ clkset0(i, &default_ddr3_800_ctrl[s->nmode - 1]
+ [CLKSET0]);
+ clkset1(i, &default_ddr3_800_ctrl[s->nmode - 1]
+ [CLKSET1]);
+ ctrlset0(i, &default_ddr3_800_ctrl[s->nmode - 1]
+ [CTRL0]);
+ ctrlset1(i, &default_ddr3_800_ctrl[s->nmode - 1]
+ [CTRL1]);
+ ctrlset2(i, &default_ddr3_800_ctrl[s->nmode - 1]
+ [CTRL2]);
+ ctrlset3(i, &default_ddr3_800_ctrl[s->nmode - 1]
+ [CTRL3]);
+ cmdset(i, &default_ddr3_800_ctrl[s->nmode - 1]
+ [CMD]);
+ }
+ break;
+ case MEM_CLOCK_1066MHz:
+ clkset0(i, &default_ddr3_1067_ctrl[s->nmode - 1]
+ [CLKSET0]);
+ clkset1(i, &default_ddr3_1067_ctrl[s->nmode - 1]
+ [CLKSET1]);
+ ctrlset0(i, &default_ddr3_1067_ctrl[s->nmode - 1]
+ [CTRL0]);
+ ctrlset1(i, &default_ddr3_1067_ctrl[s->nmode - 1]
+ [CTRL1]);
+ ctrlset2(i, &default_ddr3_1067_ctrl[s->nmode - 1]
+ [CTRL2]);
+ ctrlset3(i, &default_ddr3_1067_ctrl[s->nmode - 1]
+ [CTRL3]);
+ cmdset(i, &default_ddr3_1067_ctrl[s->nmode - 1]
+ [CMD]);
+ break;
+ case MEM_CLOCK_1333MHz:
+ clkset0(i, &default_ddr3_1333_ctrl[s->nmode - 1]
+ [CLKSET0]);
+ clkset1(i, &default_ddr3_1333_ctrl[s->nmode - 1]
+ [CLKSET1]);
+ ctrlset0(i, &default_ddr3_1333_ctrl[s->nmode - 1]
+ [CTRL0]);
+ ctrlset1(i, &default_ddr3_1333_ctrl[s->nmode - 1]
+ [CTRL1]);
+ ctrlset2(i, &default_ddr3_1333_ctrl[s->nmode - 1]
+ [CTRL2]);
+ ctrlset3(i, &default_ddr3_1333_ctrl[s->nmode - 1]
+ [CTRL3]);
+ cmdset(i, &default_ddr3_1333_ctrl[s->nmode - 1]
+ [CMD]);
+ break;
}
}
@@ -867,23 +982,39 @@
}
clk = 0x1a;
+ if (s->selected_timings.mem_clk == MEM_CLOCK_1333MHz)
+ clk = 0x18;
if (async != 1) {
reg8 = MCHBAR8(0x188) & 0x1e;
- if (s->selected_timings.mem_clk == MEM_CLOCK_667MHz &&
- s->selected_timings.fsb_clk == FSB_CLOCK_800MHz) {
- clk = 0x10;
- } else if (s->selected_timings.mem_clk == MEM_CLOCK_800MHz) {
- clk = 0x10;
- } else {
+ switch (s->selected_timings.mem_clk) {
+ case MEM_CLOCK_667MHz:
clk = 0x1a;
+ if (s->selected_timings.fsb_clk == FSB_CLOCK_800MHz)
+ clk = 0x10;
+ break;
+ case MEM_CLOCK_800MHz:
+ case MEM_CLOCK_1066MHz:
+ clk = 0x10;
+ break;
+ case MEM_CLOCK_1333MHz:
+ clk = 0x18;
+ break;
+ default:
+ clk = 0x1a;
+ break;
}
}
+
MCHBAR8(0x180) = MCHBAR8(0x180) & ~0x80;
- if ((s->selected_timings.fsb_clk == FSB_CLOCK_800MHz) &&
- (s->selected_timings.mem_clk == MEM_CLOCK_667MHz)) {
+ if ((s->spd_type == DDR3 && s->selected_timings.mem_clk == MEM_CLOCK_1066MHz)
+ || (s->spd_type == DDR2 && s->selected_timings.fsb_clk == FSB_CLOCK_800MHz
+ && s->selected_timings.mem_clk == MEM_CLOCK_667MHz)) {
i = MCHBAR8(0x1c8) & 0xf;
- i = (i + 10) % 14;
+ if (s->spd_type == DDR2)
+ i = (i + 10) % 14;
+ else /* DDR3 */
+ i = (i + 3) % 12;
MCHBAR8(0x1c8) = (MCHBAR8(0x1c8) & ~0x1f) | i;
MCHBAR8(0x180) = MCHBAR8(0x180) | 0x10;
while (MCHBAR8(0x180) & 0x10)
@@ -929,18 +1060,33 @@
s->rt_dqs[ch][lane].tap = 7;
s->rt_dqs[ch][lane].pi = 0;
} else { /* DDR3 */
- /* TODO: DDR3 write DQ-DQS */
+ memcpy(s->dqs_settings[ch],
+ default_ddr3_800_dqs[s->nmode - 1],
+ sizeof(s->dqs_settings[ch]));
+ memcpy(s->dq_settings[ch],
+ default_ddr3_800_dq[s->nmode - 1],
+ sizeof(s->dq_settings[ch]));
s->rt_dqs[ch][lane].tap = 6;
- s->rt_dqs[ch][lane].pi = 2;
+ s->rt_dqs[ch][lane].pi = 3;
}
break;
case MEM_CLOCK_1066MHz:
- /* TODO: DDR3 write DQ-DQS */
+ memcpy(s->dqs_settings[ch],
+ default_ddr3_1067_dqs[s->nmode - 1],
+ sizeof(s->dqs_settings[ch]));
+ memcpy(s->dq_settings[ch],
+ default_ddr3_1067_dq[s->nmode - 1],
+ sizeof(s->dq_settings[ch]));
s->rt_dqs[ch][lane].tap = 5;
- s->rt_dqs[ch][lane].pi = 2;
+ s->rt_dqs[ch][lane].pi = 3;
break;
case MEM_CLOCK_1333MHz:
- /* TODO: DDR3 write DQ-DQS */
+ memcpy(s->dqs_settings[ch],
+ default_ddr3_1333_dqs[s->nmode - 1],
+ sizeof(s->dqs_settings[ch]));
+ memcpy(s->dq_settings[ch],
+ default_ddr3_1333_dq[s->nmode - 1],
+ sizeof(s->dq_settings[ch]));
s->rt_dqs[ch][lane].tap = 7;
s->rt_dqs[ch][lane].pi = 0;
break;
--
To view, visit https://review.coreboot.org/22993
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I67e48b4ae6f2076399133ba7b98ab1dfc0e0ab08
Gerrit-Change-Number: 22993
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171226/63c85a8a/attachment-0001.html>
More information about the coreboot-gerrit
mailing list