[coreboot-gerrit] Change in coreboot[master]: google/kahlee/variants/(kahlee/baseboard)/gpio.c: Convert GPIO table

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/22988 )

Change subject: google/kahlee/variants/(kahlee/baseboard)/gpio.c: Convert GPIO table
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/22988/1/src/mainboard/google/kahlee/variants/baseboard/gpio.c
File src/mainboard/google/kahlee/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/22988/1/src/mainboard/google/kahlee/variants/baseboard/gpio.c@145
PS1, Line 145: FCH_GPIO_OUTPUT_VALUE
Should this be replaced with OUTPUT_L? The way it's here, output is not enabled.


https://review.coreboot.org/#/c/22988/1/src/mainboard/google/kahlee/variants/baseboard/gpio.c@148
PS1, Line 148: FCH_GPIO_OUTPUT_VALUE
Ditto.


https://review.coreboot.org/#/c/22988/1/src/mainboard/google/kahlee/variants/baseboard/gpio.c@226
PS1, Line 226: FCH_GPIO_OUTPUT_VALUE
Ditto.



-- 
To view, visit https://review.coreboot.org/22988
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88bf2c855105a6bc458aedfc6da7725662695667
Gerrit-Change-Number: 22988
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Comment-Date: Tue, 26 Dec 2017 16:07:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171226/c77a35e8/attachment.html>