<p><a href="https://review.coreboot.org/22988">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/22988/1/src/mainboard/google/kahlee/variants/baseboard/gpio.c">File src/mainboard/google/kahlee/variants/baseboard/gpio.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22988/1/src/mainboard/google/kahlee/variants/baseboard/gpio.c@145">Patch Set #1, Line 145:</a> <code style="font-family:monospace,monospace">FCH_GPIO_OUTPUT_VALUE</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should this be replaced with OUTPUT_L? The way it's here, output is not enabled.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22988/1/src/mainboard/google/kahlee/variants/baseboard/gpio.c@148">Patch Set #1, Line 148:</a> <code style="font-family:monospace,monospace">FCH_GPIO_OUTPUT_VALUE</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ditto.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22988/1/src/mainboard/google/kahlee/variants/baseboard/gpio.c@226">Patch Set #1, Line 226:</a> <code style="font-family:monospace,monospace">FCH_GPIO_OUTPUT_VALUE</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ditto.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/22988">change 22988</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22988"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I88bf2c855105a6bc458aedfc6da7725662695667 </div>
<div style="display:none"> Gerrit-Change-Number: 22988 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 26 Dec 2017 16:07:52 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>