[coreboot-gerrit] Change in coreboot[master]: google/kahlee/BiosCallOuts.c: Remove platform_FchParams_reset

Richard Spiegel (Code Review) gerrit at coreboot.org
Tue Dec 26 16:54:06 CET 2017


Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/22989


Change subject: google/kahlee/BiosCallOuts.c: Remove platform_FchParams_reset
......................................................................

google/kahlee/BiosCallOuts.c: Remove platform_FchParams_reset

Function platform_FchParams_reset() is now an empty function, remove it,
its header declaration and its use.

BUG=b:64140392
TEST=Build kahlee.

Change-Id: I3f3efc072a2e198433d0e261dacbbd4a8ff327d7
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/mainboard/google/kahlee/BiosCallOuts.c
M src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h
M src/soc/amd/stoneyridge/BiosCallOuts.c
3 files changed, 0 insertions(+), 8 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/22989/1

diff --git a/src/mainboard/google/kahlee/BiosCallOuts.c b/src/mainboard/google/kahlee/BiosCallOuts.c
index fafe0aa..2ed1843 100644
--- a/src/mainboard/google/kahlee/BiosCallOuts.c
+++ b/src/mainboard/google/kahlee/BiosCallOuts.c
@@ -19,10 +19,6 @@
 #include <stdlib.h>
 #include <baseboard/variants.h>
 
-void platform_FchParams_reset(FCH_RESET_DATA_BLOCK *FchParams_reset)
-{
-}
-
 void platform_FchParams_env(FCH_DATA_BLOCK *FchParams_env)
 {
 	/* SDHCI/MMC configuration */
diff --git a/src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h b/src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h
index 2302889..c8c5607 100644
--- a/src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h
+++ b/src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h
@@ -59,7 +59,6 @@
 AGESA_STATUS agesa_fch_initreset(UINT32 Func, UINTN FchData, VOID *ConfigPtr);
 AGESA_STATUS agesa_fch_initenv(UINT32 Func, UINTN FchData, VOID *ConfigPtr);
 
-void platform_FchParams_reset(FCH_RESET_DATA_BLOCK *FchParams_reset);
 void platform_FchParams_env(FCH_DATA_BLOCK *FchParams_env);
 void oem_fan_control(FCH_DATA_BLOCK *FchParams);
 AGESA_STATUS platform_PcieSlotResetControl(UINT32 Func, UINTN Data,
diff --git a/src/soc/amd/stoneyridge/BiosCallOuts.c b/src/soc/amd/stoneyridge/BiosCallOuts.c
index f6ac187..5ec1449 100644
--- a/src/soc/amd/stoneyridge/BiosCallOuts.c
+++ b/src/soc/amd/stoneyridge/BiosCallOuts.c
@@ -38,9 +38,6 @@
 		FchParams_reset->FchReset.SataEnable = sb_sata_enable();
 		FchParams_reset->FchReset.IdeEnable = sb_ide_enable();
 
-		/* Get platform specific configuration changes */
-		platform_FchParams_reset(FchParams_reset);
-
 		printk(BIOS_DEBUG, "Done\n");
 	}
 

-- 
To view, visit https://review.coreboot.org/22989
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f3efc072a2e198433d0e261dacbbd4a8ff327d7
Gerrit-Change-Number: 22989
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171226/2fc27fe3/attachment.html>


More information about the coreboot-gerrit mailing list