<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22989">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/kahlee/BiosCallOuts.c: Remove platform_FchParams_reset<br><br>Function platform_FchParams_reset() is now an empty function, remove it,<br>its header declaration and its use.<br><br>BUG=b:64140392<br>TEST=Build kahlee.<br><br>Change-Id: I3f3efc072a2e198433d0e261dacbbd4a8ff327d7<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/mainboard/google/kahlee/BiosCallOuts.c<br>M src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h<br>M src/soc/amd/stoneyridge/BiosCallOuts.c<br>3 files changed, 0 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/22989/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/BiosCallOuts.c b/src/mainboard/google/kahlee/BiosCallOuts.c</span><br><span>index fafe0aa..2ed1843 100644</span><br><span>--- a/src/mainboard/google/kahlee/BiosCallOuts.c</span><br><span>+++ b/src/mainboard/google/kahlee/BiosCallOuts.c</span><br><span>@@ -19,10 +19,6 @@</span><br><span> #include <stdlib.h></span><br><span> #include <baseboard/variants.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void platform_FchParams_reset(FCH_RESET_DATA_BLOCK *FchParams_reset)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> void platform_FchParams_env(FCH_DATA_BLOCK *FchParams_env)</span><br><span> {</span><br><span>      /* SDHCI/MMC configuration */</span><br><span>diff --git a/src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h b/src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h</span><br><span>index 2302889..c8c5607 100644</span><br><span>--- a/src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h</span><br><span>+++ b/src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h</span><br><span>@@ -59,7 +59,6 @@</span><br><span> AGESA_STATUS agesa_fch_initreset(UINT32 Func, UINTN FchData, VOID *ConfigPtr);</span><br><span> AGESA_STATUS agesa_fch_initenv(UINT32 Func, UINTN FchData, VOID *ConfigPtr);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void platform_FchParams_reset(FCH_RESET_DATA_BLOCK *FchParams_reset);</span><br><span> void platform_FchParams_env(FCH_DATA_BLOCK *FchParams_env);</span><br><span> void oem_fan_control(FCH_DATA_BLOCK *FchParams);</span><br><span> AGESA_STATUS platform_PcieSlotResetControl(UINT32 Func, UINTN Data,</span><br><span>diff --git a/src/soc/amd/stoneyridge/BiosCallOuts.c b/src/soc/amd/stoneyridge/BiosCallOuts.c</span><br><span>index f6ac187..5ec1449 100644</span><br><span>--- a/src/soc/amd/stoneyridge/BiosCallOuts.c</span><br><span>+++ b/src/soc/amd/stoneyridge/BiosCallOuts.c</span><br><span>@@ -38,9 +38,6 @@</span><br><span>             FchParams_reset->FchReset.SataEnable = sb_sata_enable();</span><br><span>          FchParams_reset->FchReset.IdeEnable = sb_ide_enable();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-           /* Get platform specific configuration changes */</span><br><span style="color: hsl(0, 100%, 40%);">-               platform_FchParams_reset(FchParams_reset);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>           printk(BIOS_DEBUG, "Done\n");</span><br><span>      }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/22989">change 22989</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22989"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3f3efc072a2e198433d0e261dacbbd4a8ff327d7 </div>
<div style="display:none"> Gerrit-Change-Number: 22989 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>