[coreboot-gerrit] Change in coreboot[master]: mb/hp/xxx0p: set ACPI and SLPT bit in _WAK and _PTS

[Arthur Heymans (Code Review)]

Arthur Heymans has submitted this change and it was merged. ( https://review.coreboot.org/22929 )

Change subject: mb/hp/xxx0p: set ACPI and SLPT bit in _WAK and _PTS
......................................................................

mb/hp/xxx0p: set ACPI and SLPT bit in _WAK and _PTS

ACPI bit is not set after an S3 resume, so set it in _WAK. Setting
SLPT bit can make the power LED blink in S3.

Change-Id: I2badc69510275df57938cb8607b3c4e0df50f028
Signed-off-by: Iru Cai <mytbk920423 at gmail.com>
Reviewed-on: https://review.coreboot.org/22929
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/mainboard/hp/2570p/acpi/platform.asl
M src/mainboard/hp/2760p/acpi/platform.asl
M src/mainboard/hp/8460p/acpi/platform.asl
M src/mainboard/hp/8470p/acpi/platform.asl
4 files changed, 16 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved



diff --git a/src/mainboard/hp/2570p/acpi/platform.asl b/src/mainboard/hp/2570p/acpi/platform.asl
index 79eddcb..fe0f936 100644
--- a/src/mainboard/hp/2570p/acpi/platform.asl
+++ b/src/mainboard/hp/2570p/acpi/platform.asl
@@ -15,9 +15,13 @@
 
 Method(_WAK,1)
 {
+	\_SB.PCI0.LPCB.EC0.ACPI = 1
+	\_SB.PCI0.LPCB.EC0.SLPT = 0
+
 	Return(Package(){0,0})
 }
 
 Method(_PTS,1)
 {
+	\_SB.PCI0.LPCB.EC0.SLPT = Arg0
 }
diff --git a/src/mainboard/hp/2760p/acpi/platform.asl b/src/mainboard/hp/2760p/acpi/platform.asl
index 79eddcb..fe0f936 100644
--- a/src/mainboard/hp/2760p/acpi/platform.asl
+++ b/src/mainboard/hp/2760p/acpi/platform.asl
@@ -15,9 +15,13 @@
 
 Method(_WAK,1)
 {
+	\_SB.PCI0.LPCB.EC0.ACPI = 1
+	\_SB.PCI0.LPCB.EC0.SLPT = 0
+
 	Return(Package(){0,0})
 }
 
 Method(_PTS,1)
 {
+	\_SB.PCI0.LPCB.EC0.SLPT = Arg0
 }
diff --git a/src/mainboard/hp/8460p/acpi/platform.asl b/src/mainboard/hp/8460p/acpi/platform.asl
index 79eddcb..fe0f936 100644
--- a/src/mainboard/hp/8460p/acpi/platform.asl
+++ b/src/mainboard/hp/8460p/acpi/platform.asl
@@ -15,9 +15,13 @@
 
 Method(_WAK,1)
 {
+	\_SB.PCI0.LPCB.EC0.ACPI = 1
+	\_SB.PCI0.LPCB.EC0.SLPT = 0
+
 	Return(Package(){0,0})
 }
 
 Method(_PTS,1)
 {
+	\_SB.PCI0.LPCB.EC0.SLPT = Arg0
 }
diff --git a/src/mainboard/hp/8470p/acpi/platform.asl b/src/mainboard/hp/8470p/acpi/platform.asl
index 79eddcb..fe0f936 100644
--- a/src/mainboard/hp/8470p/acpi/platform.asl
+++ b/src/mainboard/hp/8470p/acpi/platform.asl
@@ -15,9 +15,13 @@
 
 Method(_WAK,1)
 {
+	\_SB.PCI0.LPCB.EC0.ACPI = 1
+	\_SB.PCI0.LPCB.EC0.SLPT = 0
+
 	Return(Package(){0,0})
 }
 
 Method(_PTS,1)
 {
+	\_SB.PCI0.LPCB.EC0.SLPT = Arg0
 }

-- 
To view, visit https://review.coreboot.org/22929
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2badc69510275df57938cb8607b3c4e0df50f028
Gerrit-Change-Number: 22929
Gerrit-PatchSet: 2
Gerrit-Owner: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171219/366d0ec3/attachment.html>