<p>Arthur Heymans <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/22929">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/hp/xxx0p: set ACPI and SLPT bit in _WAK and _PTS<br><br>ACPI bit is not set after an S3 resume, so set it in _WAK. Setting<br>SLPT bit can make the power LED blink in S3.<br><br>Change-Id: I2badc69510275df57938cb8607b3c4e0df50f028<br>Signed-off-by: Iru Cai <mytbk920423@gmail.com><br>Reviewed-on: https://review.coreboot.org/22929<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/mainboard/hp/2570p/acpi/platform.asl<br>M src/mainboard/hp/2760p/acpi/platform.asl<br>M src/mainboard/hp/8460p/acpi/platform.asl<br>M src/mainboard/hp/8470p/acpi/platform.asl<br>4 files changed, 16 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/hp/2570p/acpi/platform.asl b/src/mainboard/hp/2570p/acpi/platform.asl</span><br><span>index 79eddcb..fe0f936 100644</span><br><span>--- a/src/mainboard/hp/2570p/acpi/platform.asl</span><br><span>+++ b/src/mainboard/hp/2570p/acpi/platform.asl</span><br><span>@@ -15,9 +15,13 @@</span><br><span> </span><br><span> Method(_WAK,1)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+    \_SB.PCI0.LPCB.EC0.ACPI = 1</span><br><span style="color: hsl(120, 100%, 40%);">+   \_SB.PCI0.LPCB.EC0.SLPT = 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>        Return(Package(){0,0})</span><br><span> }</span><br><span> </span><br><span> Method(_PTS,1)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+        \_SB.PCI0.LPCB.EC0.SLPT = Arg0</span><br><span> }</span><br><span>diff --git a/src/mainboard/hp/2760p/acpi/platform.asl b/src/mainboard/hp/2760p/acpi/platform.asl</span><br><span>index 79eddcb..fe0f936 100644</span><br><span>--- a/src/mainboard/hp/2760p/acpi/platform.asl</span><br><span>+++ b/src/mainboard/hp/2760p/acpi/platform.asl</span><br><span>@@ -15,9 +15,13 @@</span><br><span> </span><br><span> Method(_WAK,1)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+      \_SB.PCI0.LPCB.EC0.ACPI = 1</span><br><span style="color: hsl(120, 100%, 40%);">+   \_SB.PCI0.LPCB.EC0.SLPT = 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>        Return(Package(){0,0})</span><br><span> }</span><br><span> </span><br><span> Method(_PTS,1)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+        \_SB.PCI0.LPCB.EC0.SLPT = Arg0</span><br><span> }</span><br><span>diff --git a/src/mainboard/hp/8460p/acpi/platform.asl b/src/mainboard/hp/8460p/acpi/platform.asl</span><br><span>index 79eddcb..fe0f936 100644</span><br><span>--- a/src/mainboard/hp/8460p/acpi/platform.asl</span><br><span>+++ b/src/mainboard/hp/8460p/acpi/platform.asl</span><br><span>@@ -15,9 +15,13 @@</span><br><span> </span><br><span> Method(_WAK,1)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+      \_SB.PCI0.LPCB.EC0.ACPI = 1</span><br><span style="color: hsl(120, 100%, 40%);">+   \_SB.PCI0.LPCB.EC0.SLPT = 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>        Return(Package(){0,0})</span><br><span> }</span><br><span> </span><br><span> Method(_PTS,1)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+        \_SB.PCI0.LPCB.EC0.SLPT = Arg0</span><br><span> }</span><br><span>diff --git a/src/mainboard/hp/8470p/acpi/platform.asl b/src/mainboard/hp/8470p/acpi/platform.asl</span><br><span>index 79eddcb..fe0f936 100644</span><br><span>--- a/src/mainboard/hp/8470p/acpi/platform.asl</span><br><span>+++ b/src/mainboard/hp/8470p/acpi/platform.asl</span><br><span>@@ -15,9 +15,13 @@</span><br><span> </span><br><span> Method(_WAK,1)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+      \_SB.PCI0.LPCB.EC0.ACPI = 1</span><br><span style="color: hsl(120, 100%, 40%);">+   \_SB.PCI0.LPCB.EC0.SLPT = 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>        Return(Package(){0,0})</span><br><span> }</span><br><span> </span><br><span> Method(_PTS,1)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+        \_SB.PCI0.LPCB.EC0.SLPT = Arg0</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/22929">change 22929</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22929"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I2badc69510275df57938cb8607b3c4e0df50f028 </div>
<div style="display:none"> Gerrit-Change-Number: 22929 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Iru Cai <mytbk920423@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>