[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge/chip.c: Move setup_bsp_ramtop to soc_init()

Richard Spiegel (Code Review) gerrit at coreboot.org
Tue Dec 19 18:25:42 CET 2017


Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/22948


Change subject: soc/amd/stoneyridge/chip.c: Move setup_bsp_ramtop to soc_init()
......................................................................

soc/amd/stoneyridge/chip.c: Move setup_bsp_ramtop to soc_init()

Issue first reported at commit 1587dc8a2b, the call of functions
setup_bsp_ramtop() and setup_uma_memory() should be moved from enable_dev()
to soc_init(). The function setup_uma_memory() no longer exists, its
functionality transfered to agesawrapper_amdinitpost.

Move setup_bsp_ramtop() as required.

BUG=b:62240756
TEST=Build and boot kahlee.

Change-Id: I44e6cab17a8f7f364fc57657f41b211ec9d17641
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/soc/amd/stoneyridge/chip.c
1 file changed, 7 insertions(+), 7 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/22948/1

diff --git a/src/soc/amd/stoneyridge/chip.c b/src/soc/amd/stoneyridge/chip.c
index 2602be5..87f3e15 100644
--- a/src/soc/amd/stoneyridge/chip.c
+++ b/src/soc/amd/stoneyridge/chip.c
@@ -45,13 +45,6 @@
 
 static void enable_dev(device_t dev)
 {
-	static int done = 0;
-
-	if (!done) {
-		setup_bsp_ramtop();
-		done = 1;
-	}
-
 	/* Set the operations if it is a special bus type */
 	if (dev->path.type == DEVICE_PATH_DOMAIN)
 		dev->ops = &pci_domain_ops;
@@ -63,7 +56,14 @@
 
 static void soc_init(void *chip_info)
 {
+	static int done = 0;
+
 	southbridge_init(chip_info);
+	if (!done) {
+		setup_bsp_ramtop();
+		done = 1;
+	}
+
 }
 
 static void soc_final(void *chip_info)

-- 
To view, visit https://review.coreboot.org/22948
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I44e6cab17a8f7f364fc57657f41b211ec9d17641
Gerrit-Change-Number: 22948
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171219/5163a6ff/attachment-0001.html>


More information about the coreboot-gerrit mailing list