<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22948">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/amd/stoneyridge/chip.c: Move setup_bsp_ramtop to soc_init()<br><br>Issue first reported at commit 1587dc8a2b, the call of functions<br>setup_bsp_ramtop() and setup_uma_memory() should be moved from enable_dev()<br>to soc_init(). The function setup_uma_memory() no longer exists, its<br>functionality transfered to agesawrapper_amdinitpost.<br><br>Move setup_bsp_ramtop() as required.<br><br>BUG=b:62240756<br>TEST=Build and boot kahlee.<br><br>Change-Id: I44e6cab17a8f7f364fc57657f41b211ec9d17641<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/soc/amd/stoneyridge/chip.c<br>1 file changed, 7 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/22948/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/stoneyridge/chip.c b/src/soc/amd/stoneyridge/chip.c</span><br><span>index 2602be5..87f3e15 100644</span><br><span>--- a/src/soc/amd/stoneyridge/chip.c</span><br><span>+++ b/src/soc/amd/stoneyridge/chip.c</span><br><span>@@ -45,13 +45,6 @@</span><br><span> </span><br><span> static void enable_dev(device_t dev)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       static int done = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-    if (!done) {</span><br><span style="color: hsl(0, 100%, 40%);">-            setup_bsp_ramtop();</span><br><span style="color: hsl(0, 100%, 40%);">-             done = 1;</span><br><span style="color: hsl(0, 100%, 40%);">-       }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    /* Set the operations if it is a special bus type */</span><br><span>         if (dev->path.type == DEVICE_PATH_DOMAIN)</span><br><span>                 dev->ops = &pci_domain_ops;</span><br><span>@@ -63,7 +56,14 @@</span><br><span> </span><br><span> static void soc_init(void *chip_info)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+     static int done = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>       southbridge_init(chip_info);</span><br><span style="color: hsl(120, 100%, 40%);">+  if (!done) {</span><br><span style="color: hsl(120, 100%, 40%);">+          setup_bsp_ramtop();</span><br><span style="color: hsl(120, 100%, 40%);">+           done = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> }</span><br><span> </span><br><span> static void soc_final(void *chip_info)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/22948">change 22948</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22948"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I44e6cab17a8f7f364fc57657f41b211ec9d17641 </div>
<div style="display:none"> Gerrit-Change-Number: 22948 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>