[coreboot-gerrit] Change in coreboot[master]: security/tpm: Add TPM measurement code

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/22867 )

Change subject: security/tpm: Add TPM measurement code
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/22867/4/src/security/tpm/tss/tcg-1.2/tss.c
File src/security/tpm/tss/tcg-1.2/tss.c:

https://review.coreboot.org/#/c/22867/4/src/security/tpm/tss/tcg-1.2/tss.c@489
PS4, Line 489: 	*ptr += 1;
you are incrementing the entry counter twice in case the cbmem entry already exists. Has to be moved to else { ... }



-- 
To view, visit https://review.coreboot.org/22867
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a52494f647d21e2587231af26ed13d62b3a72f5
Gerrit-Change-Number: 22867
Gerrit-PatchSet: 4
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 19 Dec 2017 08:27:19 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171219/c679d8d6/attachment.html>