[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy: Configure GPP_F3 as NC

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/22917


Change subject: mb/google/poppy: Configure GPP_F3 as NC
......................................................................

mb/google/poppy: Configure GPP_F3 as NC

GPP_F3 is not connected on poppy or any of its variants. This change
configures GPP_F3 as NC on poppy and all the variants.

BUG=b:70160119

Change-Id: I303276ab9546d56c846755fa3a6142978f6b8c92
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/mainboard/google/poppy/variants/baseboard/gpio.c
M src/mainboard/google/poppy/variants/nami/gpio.c
M src/mainboard/google/poppy/variants/nautilus/gpio.c
M src/mainboard/google/poppy/variants/soraka/gpio.c
4 files changed, 8 insertions(+), 8 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/22917/1

diff --git a/src/mainboard/google/poppy/variants/baseboard/gpio.c b/src/mainboard/google/poppy/variants/baseboard/gpio.c
index 1689fc2..237f391 100644
--- a/src/mainboard/google/poppy/variants/baseboard/gpio.c
+++ b/src/mainboard/google/poppy/variants/baseboard/gpio.c
@@ -265,8 +265,8 @@
 	PAD_CFG_GPI_GPIO_DRIVER(GPP_F1, NONE, DEEP),
 	/* F2  : I2S2_TXD ==> I2S2_PCH_TX_SPKR_RX_R */
 	PAD_CFG_GPI_GPIO_DRIVER(GPP_F2, NONE, DEEP),
-	/* F3  : I2S2_RXD */
-	PAD_CFG_GPI_GPIO_DRIVER(GPP_F3, NONE, DEEP),
+	/* F3  : I2S2_RXD ==> NC */
+	PAD_CFG_NC(GPP_F3),
 	/* F4  : I2C2_SDA ==> PCH_I2C2_CAM_PMIC_1V8_SDA */
 	PAD_CFG_NF_1V8(GPP_F4, NONE, DEEP, NF1),
 	/* F5  : I2C2_SCL ==> PCH_I2C2_CAM_PMIC_1V8_SCL */
diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c
index eaafe04..6e13de8 100644
--- a/src/mainboard/google/poppy/variants/nami/gpio.c
+++ b/src/mainboard/google/poppy/variants/nami/gpio.c
@@ -265,8 +265,8 @@
 	PAD_CFG_GPI_GPIO_DRIVER(GPP_F1, NONE, DEEP),
 	/* F2  : I2S2_TXD ==> I2S2_PCH_TX_SPKR_RX_R */
 	PAD_CFG_GPI_GPIO_DRIVER(GPP_F2, NONE, DEEP),
-	/* F3  : I2S2_RXD */
-	PAD_CFG_GPI_GPIO_DRIVER(GPP_F3, NONE, DEEP),
+	/* F3  : I2S2_RXD ==> NC */
+	PAD_CFG_NC(GPP_F3),
 	/* F4  : I2C2_SDA ==> I2C_2_SDA */
 	PAD_CFG_NF_1V8(GPP_F4, NONE, DEEP, NF1),
 	/* F5  : I2C2_SCL ==> I2C_2_SCL */
diff --git a/src/mainboard/google/poppy/variants/nautilus/gpio.c b/src/mainboard/google/poppy/variants/nautilus/gpio.c
index d1dc18a..ca05ae9 100644
--- a/src/mainboard/google/poppy/variants/nautilus/gpio.c
+++ b/src/mainboard/google/poppy/variants/nautilus/gpio.c
@@ -265,8 +265,8 @@
 	PAD_CFG_GPI(GPP_F1, NONE, DEEP),
 	/* F2  : I2S2_TXD ==> CHP1_I2S2_PCH_TX_SPKR_RX_R */
 	PAD_CFG_GPI(GPP_F2, NONE, DEEP),
-	/* F3  : I2S2_RXD */
-	PAD_CFG_GPI(GPP_F3, NONE, DEEP),
+	/* F3  : I2S2_RXD ==> NC */
+	PAD_CFG_NC(GPP_F3),
 	/* F4  : I2C2_SDA ==> CHP1_I2C2_CAM_PMIC_SDA */
 	PAD_CFG_NF_1V8(GPP_F4, NONE, DEEP, NF1),
 	/* F5  : I2C2_SCL ==> CHP1_I2C2_CAM_PMIC_SCL */
diff --git a/src/mainboard/google/poppy/variants/soraka/gpio.c b/src/mainboard/google/poppy/variants/soraka/gpio.c
index e172712..50bac4b 100644
--- a/src/mainboard/google/poppy/variants/soraka/gpio.c
+++ b/src/mainboard/google/poppy/variants/soraka/gpio.c
@@ -265,8 +265,8 @@
 	PAD_CFG_GPI_GPIO_DRIVER(GPP_F1, NONE, DEEP),
 	/* F2  : I2S2_TXD ==> I2S2_PCH_TX_SPKR_RX_R */
 	PAD_CFG_GPI_GPIO_DRIVER(GPP_F2, NONE, DEEP),
-	/* F3  : I2S2_RXD */
-	PAD_CFG_GPI_GPIO_DRIVER(GPP_F3, NONE, DEEP),
+	/* F3  : I2S2_RXD ==> NC */
+	PAD_CFG_NC(GPP_F3),
 	/* F4  : I2C2_SDA ==> PCH_I2C2_CAM_PMIC_1V8_SDA */
 	PAD_CFG_NF_1V8(GPP_F4, NONE, DEEP, NF1),
 	/* F5  : I2C2_SCL ==> PCH_I2C2_CAM_PMIC_1V8_SCL */

-- 
To view, visit https://review.coreboot.org/22917
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I303276ab9546d56c846755fa3a6142978f6b8c92
Gerrit-Change-Number: 22917
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171217/c8e59460/attachment.html>