<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22917">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy: Configure GPP_F3 as NC<br><br>GPP_F3 is not connected on poppy or any of its variants. This change<br>configures GPP_F3 as NC on poppy and all the variants.<br><br>BUG=b:70160119<br><br>Change-Id: I303276ab9546d56c846755fa3a6142978f6b8c92<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/mainboard/google/poppy/variants/baseboard/gpio.c<br>M src/mainboard/google/poppy/variants/nami/gpio.c<br>M src/mainboard/google/poppy/variants/nautilus/gpio.c<br>M src/mainboard/google/poppy/variants/soraka/gpio.c<br>4 files changed, 8 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/22917/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/poppy/variants/baseboard/gpio.c b/src/mainboard/google/poppy/variants/baseboard/gpio.c<br>index 1689fc2..237f391 100644<br>--- a/src/mainboard/google/poppy/variants/baseboard/gpio.c<br>+++ b/src/mainboard/google/poppy/variants/baseboard/gpio.c<br>@@ -265,8 +265,8 @@<br>   PAD_CFG_GPI_GPIO_DRIVER(GPP_F1, NONE, DEEP),<br>  /* F2  : I2S2_TXD ==> I2S2_PCH_TX_SPKR_RX_R */<br>     PAD_CFG_GPI_GPIO_DRIVER(GPP_F2, NONE, DEEP),<br>- /* F3  : I2S2_RXD */<br>- PAD_CFG_GPI_GPIO_DRIVER(GPP_F3, NONE, DEEP),<br>+ /* F3  : I2S2_RXD ==> NC */<br>+       PAD_CFG_NC(GPP_F3),<br>   /* F4  : I2C2_SDA ==> PCH_I2C2_CAM_PMIC_1V8_SDA */<br>         PAD_CFG_NF_1V8(GPP_F4, NONE, DEEP, NF1),<br>      /* F5  : I2C2_SCL ==> PCH_I2C2_CAM_PMIC_1V8_SCL */<br>diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c<br>index eaafe04..6e13de8 100644<br>--- a/src/mainboard/google/poppy/variants/nami/gpio.c<br>+++ b/src/mainboard/google/poppy/variants/nami/gpio.c<br>@@ -265,8 +265,8 @@<br>       PAD_CFG_GPI_GPIO_DRIVER(GPP_F1, NONE, DEEP),<br>  /* F2  : I2S2_TXD ==> I2S2_PCH_TX_SPKR_RX_R */<br>     PAD_CFG_GPI_GPIO_DRIVER(GPP_F2, NONE, DEEP),<br>- /* F3  : I2S2_RXD */<br>- PAD_CFG_GPI_GPIO_DRIVER(GPP_F3, NONE, DEEP),<br>+ /* F3  : I2S2_RXD ==> NC */<br>+       PAD_CFG_NC(GPP_F3),<br>   /* F4  : I2C2_SDA ==> I2C_2_SDA */<br>         PAD_CFG_NF_1V8(GPP_F4, NONE, DEEP, NF1),<br>      /* F5  : I2C2_SCL ==> I2C_2_SCL */<br>diff --git a/src/mainboard/google/poppy/variants/nautilus/gpio.c b/src/mainboard/google/poppy/variants/nautilus/gpio.c<br>index d1dc18a..ca05ae9 100644<br>--- a/src/mainboard/google/poppy/variants/nautilus/gpio.c<br>+++ b/src/mainboard/google/poppy/variants/nautilus/gpio.c<br>@@ -265,8 +265,8 @@<br>       PAD_CFG_GPI(GPP_F1, NONE, DEEP),<br>      /* F2  : I2S2_TXD ==> CHP1_I2S2_PCH_TX_SPKR_RX_R */<br>        PAD_CFG_GPI(GPP_F2, NONE, DEEP),<br>-     /* F3  : I2S2_RXD */<br>- PAD_CFG_GPI(GPP_F3, NONE, DEEP),<br>+     /* F3  : I2S2_RXD ==> NC */<br>+       PAD_CFG_NC(GPP_F3),<br>   /* F4  : I2C2_SDA ==> CHP1_I2C2_CAM_PMIC_SDA */<br>    PAD_CFG_NF_1V8(GPP_F4, NONE, DEEP, NF1),<br>      /* F5  : I2C2_SCL ==> CHP1_I2C2_CAM_PMIC_SCL */<br>diff --git a/src/mainboard/google/poppy/variants/soraka/gpio.c b/src/mainboard/google/poppy/variants/soraka/gpio.c<br>index e172712..50bac4b 100644<br>--- a/src/mainboard/google/poppy/variants/soraka/gpio.c<br>+++ b/src/mainboard/google/poppy/variants/soraka/gpio.c<br>@@ -265,8 +265,8 @@<br>  PAD_CFG_GPI_GPIO_DRIVER(GPP_F1, NONE, DEEP),<br>  /* F2  : I2S2_TXD ==> I2S2_PCH_TX_SPKR_RX_R */<br>     PAD_CFG_GPI_GPIO_DRIVER(GPP_F2, NONE, DEEP),<br>- /* F3  : I2S2_RXD */<br>- PAD_CFG_GPI_GPIO_DRIVER(GPP_F3, NONE, DEEP),<br>+ /* F3  : I2S2_RXD ==> NC */<br>+       PAD_CFG_NC(GPP_F3),<br>   /* F4  : I2C2_SDA ==> PCH_I2C2_CAM_PMIC_1V8_SDA */<br>         PAD_CFG_NF_1V8(GPP_F4, NONE, DEEP, NF1),<br>      /* F5  : I2C2_SCL ==> PCH_I2C2_CAM_PMIC_1V8_SCL */<br></pre><p>To view, visit <a href="https://review.coreboot.org/22917">change 22917</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22917"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I303276ab9546d56c846755fa3a6142978f6b8c92 </div>
<div style="display:none"> Gerrit-Change-Number: 22917 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>